crosstest/crosstest.py - Issue 444443002: Subzero: Align the stack at the point of function calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crosstest/crosstest.py

Issue 444443002: Subzero: Align the stack at the point of function calls. (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Patch Set: Comments round 3 Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: crosstest/crosstest.py

diff --git a/crosstest/crosstest.py b/crosstest/crosstest.py

index 9b64399074021059df6e3d372f929cfb45dd19ed..89124d6c26c52f219a1d3a37c2f93fea563fb07a 100755

--- a/crosstest/crosstest.py

+++ b/crosstest/crosstest.py

@@ -134,7 +134,6 @@ if __name__ == '__main__':

objs.append(bitcode)

linker = 'clang' if os.path.splitext(args.driver)[1] == '.c' else 'clang++'

- # TODO: Remove -mstackrealign after Subzero supports stack alignment.

- shellcmd([os.path.join(llvm_bin_path, linker), '-g', '-m32',

- '-mstackrealign', args.driver] + objs +

+ shellcmd([os.path.join(llvm_bin_path, linker), '-g', '-m32', args.driver] +

+ objs +

['-lm', '-lpthread', '-o', os.path.join(args.dir, args.output)])

« no previous file with comments | « no previous file | crosstest/runtests.sh » ('j') | no next file with comments »