Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: dm/DM.cpp

Issue 44443002: DM: move --match check earlier to fix the "N GMs x M configs" log line. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DM.cpp
diff --git a/dm/DM.cpp b/dm/DM.cpp
index aca4986a25640d27c4d10c1ed7c83149922fc073..8c30fe6b55aebb8f8e0ee72df46be10bbced49ba 100644
--- a/dm/DM.cpp
+++ b/dm/DM.cpp
@@ -84,9 +84,6 @@ static void kick_off_tasks(const SkTDArray<GMRegistry::Factory>& gms,
#endif
for (int i = 0; i < gms.count(); i++) {
- SkAutoTDelete<GM> gmForName(gms[i](NULL));
- if (SkCommandLineFlags::ShouldSkip(FLAGS_match, gmForName->shortName())) continue;
-
#define START(name, type, ...) \
if (lowercase(configs[j]).equals(name)) { \
tasks->add(SkNEW_ARGS(DM::type, \
@@ -142,7 +139,10 @@ int tool_main(int argc, char** argv) {
SkTDArray<GMRegistry::Factory> gms;
for (const GMRegistry* reg = GMRegistry::Head(); reg != NULL; reg = reg->next()) {
- *gms.append() = reg->factory();
+ SkAutoTDelete<GM> gmForName(reg->factory()(NULL));
+ if (!SkCommandLineFlags::ShouldSkip(FLAGS_match, gmForName->shortName())) {
+ *gms.append() = reg->factory();
+ }
}
SkDebugf("%d GMs x %d configs\n", gms.count(), configs.count());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698