Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 444423002: Update V8 to version 3.28.62 (based on bleeding_edge revision r22958). (Closed)

Created:
6 years, 4 months ago by Michael Achenbach
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Update V8 to version 3.28.62 (based on bleeding_edge revision r22958). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288069

Patch Set 1 #

Patch Set 2 : License suppression. #

Total comments: 1

Patch Set 3 : Android compatible license. #

Patch Set 4 : Recognize license. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/devscripts/licensecheck.pl View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/licenses.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Michael Achenbach
6 years, 4 months ago (2014-08-07 08:47:25 UTC) #1
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 4 months ago (2014-08-07 08:47:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/444423002/1
6 years, 4 months ago (2014-08-07 08:49:39 UTC) #3
Hannes Payer (out of office)
lgtm
6 years, 4 months ago (2014-08-07 08:52:06 UTC) #4
Michael Achenbach
FYI: license suppression from yangguo.
6 years, 4 months ago (2014-08-07 10:07:04 UTC) #5
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 4 months ago (2014-08-07 10:07:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/444423002/20001
6 years, 4 months ago (2014-08-07 10:08:24 UTC) #7
Paweł Hajdan Jr.
The CQ bit was unchecked by phajdan.jr@chromium.org
6 years, 4 months ago (2014-08-07 11:35:16 UTC) #8
Paweł Hajdan Jr.
https://codereview.chromium.org/444423002/diff/20001/tools/checklicenses/checklicenses.py File tools/checklicenses/checklicenses.py (right): https://codereview.chromium.org/444423002/diff/20001/tools/checklicenses/checklicenses.py#newcode402 tools/checklicenses/checklicenses.py:402: 'v8/third_party/fdlibm': [ # fdlibm is "Freely Distributable". Please don't ...
6 years, 4 months ago (2014-08-07 11:36:08 UTC) #9
Yang
On 2014/08/07 11:36:08, Paweł Hajdan Jr. wrote: > https://codereview.chromium.org/444423002/diff/20001/tools/checklicenses/checklicenses.py > File tools/checklicenses/checklicenses.py (right): > > ...
6 years, 4 months ago (2014-08-07 11:40:44 UTC) #10
Michael Achenbach
phajdan PTAL
6 years, 4 months ago (2014-08-07 13:06:04 UTC) #11
Paweł Hajdan Jr.
LGTM
6 years, 4 months ago (2014-08-07 13:09:44 UTC) #12
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 4 months ago (2014-08-07 13:12:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/444423002/60001
6 years, 4 months ago (2014-08-07 13:12:44 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-07 15:57:23 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 16:20:49 UTC) #16
Message was sent while issue was closed.
Change committed as 288069

Powered by Google App Engine
This is Rietveld 408576698