Make style building for font-weight less custom.

Make style building for font-weight less custom.

This patch lets the StyleBuilderConverter produce the final values
for CSSValueBolder and CSSValueLighter, instead of first setting the
weight on FontBuilder, and then setting the weight again.

This is more in line with how the rest of the style building works.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179755

[andersr, 2014-08-07 10:01:43]

It appears that the test fast/css/font-weight-1.html currently has the wrong
baseline for at least platform/[win, linux]. This patch somehow fixes that. (I
don't really understand how).

I didn't mark it as NeedsRebaseline yet. Want to see what the bots have to say
first.

[rune, 2014-08-07 10:33:33]

On 2014/08/07 10:01:43, andersr wrote:
> It appears that the test fast/css/font-weight-1.html currently has the wrong
> baseline for at least platform/[win, linux]. This patch somehow fixes that. (I
> don't really understand how).
> 
> I didn't mark it as NeedsRebaseline yet. Want to see what the bots have to say
> first.

What exactly changed in the test result, and why is that correct?

[rune, 2014-08-07 10:42:59]

On 2014/08/07 10:33:33, rune wrote:
> On 2014/08/07 10:01:43, andersr wrote:
> > It appears that the test fast/css/font-weight-1.html currently has the wrong
> > baseline for at least platform/[win, linux]. This patch somehow fixes that.
(I
> > don't really understand how).
> > 
> > I didn't mark it as NeedsRebaseline yet. Want to see what the bots have to
say
> > first.
> 
> What exactly changed in the test result, and why is that correct?

I see. There are no numbers 1-9. And I guess those appear with your change?

[rune, 2014-08-07 10:46:21]

On 2014/08/07 10:42:59, rune wrote:
> On 2014/08/07 10:33:33, rune wrote:
> > On 2014/08/07 10:01:43, andersr wrote:
> > > It appears that the test fast/css/font-weight-1.html currently has the
wrong
> > > baseline for at least platform/[win, linux]. This patch somehow fixes
that.
> (I
> > > don't really understand how).
> > > 
> > > I didn't mark it as NeedsRebaseline yet. Want to see what the bots have to
> say
> > > first.
> > 
> > What exactly changed in the test result, and why is that correct?
> 
> I see. There are no numbers 1-9. And I guess those appear with your change?

It could be that the code you're changing is used for the font-weight descriptor
in @font-face as well as the font-weight css property.

[andersr, 2014-08-07 10:49:16]

> > I see. There are no numbers 1-9. And I guess those appear with your change?

Correct.

> It could be that the code you're changing is used for the font-weight
descriptor
> in @font-face as well as the font-weight css property.

Or there is something wrong with the test. I'll see if it can be fixed, if
that's the case.

[andersr, 2014-08-07 13:02:57]

Looks like it's just a coincidence, and that this patch actually has nothing to
do with it. The test "fails" with or without this patch locally.

Filed: https://crbug.com/401418

[dglazkov, 2014-08-07 15:44:22]

lgtm

[andersr, 2014-08-07 19:24:14]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-08-07 19:25:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/andersr@opera.com/444413003/1

[commit-bot: I haz the power, 2014-08-07 21:13:06]

Change committed as 179755