Issue 444373003: typo fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 444373003: typo fix (Closed)

Created:
6 years, 4 months ago by michaelpg

Modified:
6 years, 4 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

typo fix TBR=dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287991

Patch Set 1 : #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/options/options_settings_app.js	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

michaelpg

Committed patchset #1 manually as 287991 (presubmit successful).

6 years, 4 months ago (2014-08-07 07:36:16 UTC) #1

Dan Beam

https://codereview.chromium.org/444373003/diff/20001/chrome/browser/resources/options/options_settings_app.js File chrome/browser/resources/options/options_settings_app.js (right): https://codereview.chromium.org/444373003/diff/20001/chrome/browser/resources/options/options_settings_app.js#newcode12 chrome/browser/resources/options/options_settings_app.js:12: PageManager.horizontalOffset = 38; is there a test for this?

6 years, 4 months ago (2014-08-07 21:49:19 UTC) #2

michaelpg

6 years, 4 months ago (2014-08-07 22:02:46 UTC) #3

Message was sent while issue was closed.

On 2014/08/07 21:49:19, Dan Beam wrote:
>
https://codereview.chromium.org/444373003/diff/20001/chrome/browser/resources...
> File chrome/browser/resources/options/options_settings_app.js (right):
> 
>
https://codereview.chromium.org/444373003/diff/20001/chrome/browser/resources...
> chrome/browser/resources/options/options_settings_app.js:12:
> PageManager.horizontalOffset = 38;
> is there a test for this?

for this in particular? no, but I guess we could add it to
settings_app_browsertest.js?

Expand Messages | Collapse Messages