Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 444333007: Pipeline: Invalidate weak pointers before returning stop callback. (Closed)

Created:
6 years, 4 months ago by xhwang
Modified:
6 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Pipeline: Invalidate weak pointers before returning stop callback. This is a follow up CL of r287687, which missed the corner case that an error happened before Stop(). This CL also updated the PipelineTest so that we explicitly check that all weak pointers must have been invalidated before the stop callback returns. With this check PipelineTeardownTest.Error_* tests will cover this corner case. BUG=399417 TEST=Updated unit test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288181

Patch Set 1 #

Total comments: 2

Patch Set 2 : add HasWeakPtrsForTesting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M media/base/pipeline.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/base/pipeline.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download
M media/base/pipeline_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xhwang
Sorry I missed a corner case in the last CL. Here's the fix. I also ...
6 years, 4 months ago (2014-08-07 17:31:21 UTC) #1
scherkus (not reviewing)
lgtm w/ nit https://codereview.chromium.org/444333007/diff/1/media/base/pipeline.h File media/base/pipeline.h (right): https://codereview.chromium.org/444333007/diff/1/media/base/pipeline.h#newcode192 media/base/pipeline.h:192: friend class PipelineTest; not the biggest ...
6 years, 4 months ago (2014-08-07 18:51:52 UTC) #2
xhwang
https://codereview.chromium.org/444333007/diff/1/media/base/pipeline.h File media/base/pipeline.h (right): https://codereview.chromium.org/444333007/diff/1/media/base/pipeline.h#newcode192 media/base/pipeline.h:192: friend class PipelineTest; On 2014/08/07 18:51:52, scherkus wrote: > ...
6 years, 4 months ago (2014-08-07 19:04:35 UTC) #3
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 4 months ago (2014-08-07 19:04:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/444333007/20001
6 years, 4 months ago (2014-08-07 19:07:09 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 00:51:38 UTC) #6
Message was sent while issue was closed.
Change committed as 288181

Powered by Google App Engine
This is Rietveld 408576698