Rename ServiceWorkerFetchStore/FetchStores/FetchStoresManager

Rename ServiceWorkerFetchStore/FetchStores/FetchStoresManager
to
ServiceWorkerCache/CacheStorage/CacheStorageManager to sync up with the spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#cache-objects

BUG=392621
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288511

[jkarlin, 2014-08-08 09:44:13]

falken@chromium.org: Please review changes in everything

jochen@chromium.org: Please review changes in the content/ gypi files 

michaeln@chromium.org: FYI

[jkarlin, 2014-08-08 09:45:28]

On 2014/08/08 09:44:13, jkarlin wrote:
> mailto:falken@chromium.org: Please review changes in everything
> 
> mailto:jochen@chromium.org: Please review changes in the content/ gypi files 
> 
> mailto:michaeln@chromium.org: FYI

Removed jochen since OOO

sky: Please review changes in the content/ gypi files.  Thanks!

[falken, 2014-08-08 10:25:25]

If it's not much trouble, could you reupload with git-cl upload --similarity=1
or something? It's kind of rough that the renames aren't detected as copies.

I tried myself but somehow can't apply the patch to my checkout.

[jkarlin, 2014-08-08 10:58:42]

On 2014/08/08 10:25:25, falken wrote:
> If it's not much trouble, could you reupload with git-cl upload --similarity=1
> or something? It's kind of rough that the renames aren't detected as copies.
> 
> I tried myself but somehow can't apply the patch to my checkout.

Ah right, now I remember why I was holding off on having this reviewed.  This
renames some files that aren't landed yet :(  Hope to get that in soon.  Sorry
about that.

[falken, 2014-08-08 12:03:41]

thanks for re-uploading! much easier to review

lgtm

https://codereview.chromium.org/444333006/diff/60001/content/browser/service_...
File
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
(right):

https://codereview.chromium.org/444333006/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc:52:
int cache,
nit: maybe cache_id is better

https://codereview.chromium.org/444333006/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc:68:
bool CreateCache(const GURL& origin, std::string cache_name) {
nit: const std::string& (and on the functions below)

https://codereview.chromium.org/444333006/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc:206:
TEST_P(ServiceWorkerCacheStorageManagerTestP, Create2Caches) {
nit: CreateTwoCaches reads better to me

[sky, 2014-08-08 16:04:57]

content/*.gypi has an OWNER of *, you don't need me. I'm removing myself as a
reviewer.

[jkarlin, 2014-08-08 18:08:18]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2014-08-08 18:09:29]

The CQ bit was unchecked by jkarlin@chromium.org

[jkarlin, 2014-08-08 18:12:36]

https://codereview.chromium.org/444333006/diff/60001/content/browser/service_...
File
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
(right):

https://codereview.chromium.org/444333006/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc:52:
int cache,
On 2014/08/08 12:03:40, falken wrote:
> nit: maybe cache_id is better

Done.

https://codereview.chromium.org/444333006/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc:68:
bool CreateCache(const GURL& origin, std::string cache_name) {
On 2014/08/08 12:03:40, falken wrote:
> nit: const std::string& (and on the functions below)

Done.

https://codereview.chromium.org/444333006/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc:206:
TEST_P(ServiceWorkerCacheStorageManagerTestP, Create2Caches) {
On 2014/08/08 12:03:40, falken wrote:
> nit: CreateTwoCaches reads better to me

Done.

[jkarlin, 2014-08-08 18:12:41]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-08-08 18:14:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jkarlin@chromium.org/444333006/100001

[commit-bot: I haz the power, 2014-08-08 21:42:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 21:42:11]

Failed to apply patch for content/content_browser.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/content_browser.gypi
  Hunk #1 FAILED at 1118.
  Hunk #2 succeeded at 1141 (offset 6 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
content/content_browser.gypi.rej

Patch:       content/content_browser.gypi
Index: content/content_browser.gypi
diff --git a/content/content_browser.gypi b/content/content_browser.gypi
index
938b66da65705604835ca16d73f3db9bc4ccf244..8817965d0c8ac91ab9158aaa629c7f478f3c85d7
100644
--- a/content/content_browser.gypi
+++ b/content/content_browser.gypi
@@ -1118,6 +1118,12 @@
       'browser/service_worker/embedded_worker_instance.h',
       'browser/service_worker/embedded_worker_registry.cc',
       'browser/service_worker/embedded_worker_registry.h',
+      'browser/service_worker/service_worker_cache.cc',
+      'browser/service_worker/service_worker_cache.h',
+      'browser/service_worker/service_worker_cache_storage.cc',
+      'browser/service_worker/service_worker_cache_storage.h',      
+      'browser/service_worker/service_worker_cache_storage_manager.cc',
+      'browser/service_worker/service_worker_cache_storage_manager.h',      
       'browser/service_worker/service_worker_context_core.cc',
       'browser/service_worker/service_worker_context_core.h',
       'browser/service_worker/service_worker_context_observer.h',
@@ -1135,12 +1141,6 @@
       'browser/service_worker/service_worker_dispatcher_host.h',
       'browser/service_worker/service_worker_fetch_dispatcher.cc',
       'browser/service_worker/service_worker_fetch_dispatcher.h',
-      'browser/service_worker/service_worker_fetch_store.cc',
-      'browser/service_worker/service_worker_fetch_store.h',
-      'browser/service_worker/service_worker_fetch_stores.cc',
-      'browser/service_worker/service_worker_fetch_stores.h',      
-      'browser/service_worker/service_worker_fetch_stores_manager.cc',
-      'browser/service_worker/service_worker_fetch_stores_manager.h',
       'browser/service_worker/service_worker_handle.cc',
       'browser/service_worker/service_worker_handle.h',
       'browser/service_worker/service_worker_info.cc',

[jkarlin, 2014-08-08 21:55:57]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-08-08 21:57:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jkarlin@chromium.org/444333006/120001

[commit-bot: I haz the power, 2014-08-09 05:35:24]

Change committed as 288511