Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 444333005: Remove custom style building for -webkit-font-feature-settings. (Closed)

Created:
6 years, 4 months ago by andersr
Modified:
6 years, 4 months ago
Reviewers:
dglazkov, eae
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, Rik, danakj, dglazkov+blink, krit, ed+blinkwatch_opera.com, jamesr, jbroman, pdr., rwlbuis, rune+blink, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove custom style building for -webkit-font-feature-settings. This patch replaces the custom style application for -webkit-font-feature-settings with a function in StyleBuilderConverter. Also: * Less use of CSSValue in FontBuilder. * We now handle 'initial' and 'inherit'. * Eliminates FontDescription::makeNormalFeatureSettings. Note that in StyleBuilderConverter::convertFontFeatureSettings, the check for isFontFeatureValue() is removed. Asserting (via toCSSFontFeatureValue) should be enough, since the parser will only add CSSFontFeatureValues to the list. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -54 lines) Patch
M Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/FontBuilder.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/css/resolver/FontBuilder.cpp View 2 chunks +2 lines, -21 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 2 chunks +16 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M Source/platform/fonts/FontDescription.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/FontDescription.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
andersr
Note: Based on: https://codereview.chromium.org/444413003/
6 years, 4 months ago (2014-08-07 14:45:25 UTC) #1
dglazkov
lgtm
6 years, 4 months ago (2014-08-07 15:50:58 UTC) #2
andersr
The CQ bit was checked by andersr@opera.com
6 years, 4 months ago (2014-08-07 21:23:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/444333005/1
6 years, 4 months ago (2014-08-07 21:24:27 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 23:03:35 UTC) #5
Message was sent while issue was closed.
Change committed as 179764

Powered by Google App Engine
This is Rietveld 408576698