Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 444333002: Use a TestBrowserThreadBundle in WebUIDataSourceTest (Closed)

Created:
6 years, 4 months ago by Ryan Sleevi
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Use a TestBrowserThreadBundle in WebUIDataSourceTest It uses the //net stack, ergo it needs to have a MessageLoop BUG=395356 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288097

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/webui/web_ui_data_source_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Sleevi
arv: Can you take a look?
6 years, 4 months ago (2014-08-07 03:39:30 UTC) #1
arv (Not doing code reviews)
LGTM (Rubber stamp since I'm not sure what is going on here)
6 years, 4 months ago (2014-08-07 15:35:00 UTC) #2
Ryan Sleevi
On 2014/08/07 15:35:00, arv wrote: > LGTM > > (Rubber stamp since I'm not sure ...
6 years, 4 months ago (2014-08-07 15:39:06 UTC) #3
Ryan Sleevi
The CQ bit was checked by rsleevi@chromium.org
6 years, 4 months ago (2014-08-07 15:39:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/444333002/1
6 years, 4 months ago (2014-08-07 15:43:55 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 17:53:52 UTC) #6
Message was sent while issue was closed.
Change committed as 288097

Powered by Google App Engine
This is Rietveld 408576698