Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 444323005: Add DACL and fix test for anonymous read-only memory (Closed)

Created:
6 years, 4 months ago by jschuh
Modified:
6 years, 4 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M base/memory/shared_memory_unittest.cc View 1 2 chunks +12 lines, -1 line 0 comments Download
M base/memory/shared_memory_win.cc View 3 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jschuh
Turns out I landed only half a fix last time. This change fixes the existing ...
6 years, 4 months ago (2014-08-07 05:23:26 UTC) #1
rvargas (doing something else)
LGTM. Just a small suggestion for the test. https://codereview.chromium.org/444323005/diff/1/base/memory/shared_memory_unittest.cc File base/memory/shared_memory_unittest.cc (right): https://codereview.chromium.org/444323005/diff/1/base/memory/shared_memory_unittest.cc#newcode449 base/memory/shared_memory_unittest.cc:449: } ...
6 years, 4 months ago (2014-08-07 18:24:02 UTC) #2
jschuh
https://codereview.chromium.org/444323005/diff/1/base/memory/shared_memory_unittest.cc File base/memory/shared_memory_unittest.cc (right): https://codereview.chromium.org/444323005/diff/1/base/memory/shared_memory_unittest.cc#newcode449 base/memory/shared_memory_unittest.cc:449: } On 2014/08/07 18:24:02, rvargas wrote: > could we ...
6 years, 4 months ago (2014-08-07 18:35:48 UTC) #3
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 4 months ago (2014-08-07 18:48:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/444323005/20001
6 years, 4 months ago (2014-08-07 18:52:57 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 22:08:20 UTC) #6
Message was sent while issue was closed.
Change committed as 288152

Powered by Google App Engine
This is Rietveld 408576698