Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: net/quic/reliable_quic_stream_test.cc

Issue 444313002: Deprecate rolled out FLAGS_enable_quic_connection_flow_control_2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Final_0807
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_session_test.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/reliable_quic_stream_test.cc
diff --git a/net/quic/reliable_quic_stream_test.cc b/net/quic/reliable_quic_stream_test.cc
index f25011d5d307a6e2d1514338eaf64f542721e030..f188783e425c7a546ca262457db548d05cd3fde8 100644
--- a/net/quic/reliable_quic_stream_test.cc
+++ b/net/quic/reliable_quic_stream_test.cc
@@ -6,7 +6,6 @@
#include "net/quic/quic_ack_notifier.h"
#include "net/quic/quic_connection.h"
-#include "net/quic/quic_flags.h"
#include "net/quic/quic_utils.h"
#include "net/quic/quic_write_blocked_list.h"
#include "net/quic/spdy_utils.h"
@@ -471,9 +470,7 @@ TEST_F(ReliableQuicStreamTest, WriteOrBufferDataWithQuicAckNotifier) {
// Set a large flow control send window so this doesn't interfere with test.
stream_->flow_controller()->UpdateSendWindowOffset(kDataSize + 1);
- if (FLAGS_enable_quic_connection_flow_control_2) {
- session_->flow_controller()->UpdateSendWindowOffset(kDataSize + 1);
- }
+ session_->flow_controller()->UpdateSendWindowOffset(kDataSize + 1);
scoped_refptr<QuicAckNotifier::DelegateInterface> proxy_delegate;
@@ -526,9 +523,7 @@ TEST_F(ReliableQuicStreamTest, WriteOrBufferDataAckNotificationBeforeFlush) {
// Set a large flow control send window so this doesn't interfere with test.
stream_->flow_controller()->UpdateSendWindowOffset(kDataSize + 1);
- if (FLAGS_enable_quic_connection_flow_control_2) {
- session_->flow_controller()->UpdateSendWindowOffset(kDataSize + 1);
- }
+ session_->flow_controller()->UpdateSendWindowOffset(kDataSize + 1);
scoped_refptr<QuicAckNotifier::DelegateInterface> proxy_delegate;
@@ -634,9 +629,6 @@ TEST_F(ReliableQuicStreamTest, WriteAndBufferDataWithAckNotiferOnlyFinRemains) {
// as we check for violation and close the connection early.
TEST_F(ReliableQuicStreamTest,
StreamSequencerNeverSeesPacketsViolatingFlowControl) {
- ValueRestore<bool> old_connection_flag(
- &FLAGS_enable_quic_connection_flow_control_2, true);
-
Initialize(kShouldProcessData);
// Receive a stream frame that violates flow control: the byte offset is
« no previous file with comments | « net/quic/quic_session_test.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698