Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: net/quic/quic_session_test.cc

Issue 444313002: Deprecate rolled out FLAGS_enable_quic_connection_flow_control_2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Final_0807
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_session.cc ('k') | net/quic/reliable_quic_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_session_test.cc
diff --git a/net/quic/quic_session_test.cc b/net/quic/quic_session_test.cc
index 83f2447df80ff1697ae4437e48c3549e9dd726e0..a81d1f5bb116025fe696c70a76a56141f4f41a04 100644
--- a/net/quic/quic_session_test.cc
+++ b/net/quic/quic_session_test.cc
@@ -11,7 +11,6 @@
#include "base/containers/hash_tables.h"
#include "net/quic/crypto/crypto_protocol.h"
#include "net/quic/quic_crypto_stream.h"
-#include "net/quic/quic_flags.h"
#include "net/quic/quic_protocol.h"
#include "net/quic/quic_utils.h"
#include "net/quic/reliable_quic_stream.h"
@@ -531,8 +530,6 @@ TEST_P(QuicSessionTest, OnCanWriteLimitsNumWritesIfFlowControlBlocked) {
return;
}
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control_2,
- true);
// Ensure connection level flow control blockage.
QuicFlowControllerPeer::SetSendWindowOffset(session_.flow_controller(), 0);
EXPECT_TRUE(session_.flow_controller()->IsBlocked());
@@ -711,8 +708,6 @@ TEST_P(QuicSessionTest, ConnectionFlowControlAccountingRstOutOfOrder) {
return;
}
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control_2,
- true);
// Test that when we receive an out of order stream RST we correctly adjust
// our connection level flow control receive window.
// On close, the stream should mark as consumed all bytes between the highest
@@ -741,8 +736,6 @@ TEST_P(QuicSessionTest, ConnectionFlowControlAccountingFinAndLocalReset) {
return;
}
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control_2,
- true);
// Test the situation where we receive a FIN on a stream, and before we fully
// consume all the data from the sequencer buffer we locally RST the stream.
// The bytes between highest consumed byte, and the final byte offset that we
@@ -789,8 +782,6 @@ TEST_P(QuicSessionTest, ConnectionFlowControlAccountingFinAfterRst) {
return;
}
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control_2,
- true);
// Connection starts with some non-zero highest received byte offset,
// due to other active streams.
const uint64 kInitialConnectionBytesConsumed = 567;
@@ -833,8 +824,6 @@ TEST_P(QuicSessionTest, ConnectionFlowControlAccountingRstAfterRst) {
return;
}
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control_2,
- true);
// Connection starts with some non-zero highest received byte offset,
// due to other active streams.
const uint64 kInitialConnectionBytesConsumed = 567;
@@ -869,8 +858,6 @@ TEST_P(QuicSessionTest, FlowControlWithInvalidFinalOffset) {
if (version() <= QUIC_VERSION_16) {
return;
}
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control_2,
- true);
const uint64 kLargeOffset = kInitialSessionFlowControlWindowForTest + 1;
EXPECT_CALL(*connection_,
@@ -896,8 +883,6 @@ TEST_P(QuicSessionTest, VersionNegotiationDisablesFlowControl) {
return;
}
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_connection_flow_control_2,
- true);
// Test that after successful version negotiation, flow control is disabled
// appropriately at both the connection and stream level.
« no previous file with comments | « net/quic/quic_session.cc ('k') | net/quic/reliable_quic_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698