Migrate SkRTConfRegistry test to DEF_TEST().

Migrate SkRTConfRegistry test to DEF_TEST().

BUG=None
TEST=dm --tests=true --gms=false
R=mtklein@google.com

Committed: https://skia.googlesource.com/skia/+/35fbd014e3dd2b4e1813389da6dfa2d3482dfb67

[tfarina, 2014-08-07 03:05:40]

Finally I had some minutes to work on this.

I'm sure (at least I hope) you can help me to find a better way of doing this.

https://codereview.chromium.org/444303002/diff/1/include/utils/SkRTConf.h
File include/utils/SkRTConf.h (right):

https://codereview.chromium.org/444303002/diff/1/include/utils/SkRTConf.h#new...
include/utils/SkRTConf.h:87: template <typename T> bool parse(const char *name,
T* value);
I know you won't like this ;/

https://codereview.chromium.org/444303002/diff/1/include/utils/SkRTConf.h#new...
include/utils/SkRTConf.h:93: SkRTConfRegistry();
you will probably want me to keep the bool parameter, won't you?

[mtklein, 2014-08-07 12:26:14]

https://codereview.chromium.org/444303002/diff/1/include/utils/SkRTConf.h
File include/utils/SkRTConf.h (right):

https://codereview.chromium.org/444303002/diff/1/include/utils/SkRTConf.h#new...
include/utils/SkRTConf.h:76: SkRTConfRegistry();
SK_SUPPORT_UNITTEST is not defined anywhere.  This is the constructor you're
calling.

https://codereview.chromium.org/444303002/diff/1/include/utils/SkRTConf.h#new...
include/utils/SkRTConf.h:87: template <typename T> bool parse(const char *name,
T* value);
On 2014/08/07 03:05:40, tfarina wrote:
> I know you won't like this ;/

Seems fine, but let's keep it private and instead friend it to a proxy in the
test file?

https://codereview.chromium.org/444303002/diff/1/include/utils/SkRTConf.h#new...
include/utils/SkRTConf.h:93: SkRTConfRegistry();
On 2014/08/07 03:05:40, tfarina wrote:
> you will probably want me to keep the bool parameter, won't you?

I don't think so?   If this test works as written, it'd be better to delete this
alternative constructor entirely.  It's not being called.

https://codereview.chromium.org/444303002/diff/1/tests/RTConfRegistryTest.cpp
File tests/RTConfRegistryTest.cpp (right):

https://codereview.chromium.org/444303002/diff/1/tests/RTConfRegistryTest.cpp...
tests/RTConfRegistryTest.cpp:27: SkASSERT(result == 132);
REPORTER_ASSERT?

[tfarina, 2014-08-07 14:11:27]

https://codereview.chromium.org/444303002/diff/1/include/utils/SkRTConf.h
File include/utils/SkRTConf.h (right):

https://codereview.chromium.org/444303002/diff/1/include/utils/SkRTConf.h#new...
include/utils/SkRTConf.h:76: SkRTConfRegistry();
On 2014/08/07 12:26:14, mtklein wrote:
> SK_SUPPORT_UNITTEST is not defined anywhere.  This is the constructor you're
> calling.

Done.

https://codereview.chromium.org/444303002/diff/1/include/utils/SkRTConf.h#new...
include/utils/SkRTConf.h:87: template <typename T> bool parse(const char *name,
T* value);
On 2014/08/07 12:26:14, mtklein wrote:
> On 2014/08/07 03:05:40, tfarina wrote:
> > I know you won't like this ;/
> 
> Seems fine, but let's keep it private and instead friend it to a proxy in the
> test file?
Hum, who do I do that?

https://codereview.chromium.org/444303002/diff/1/include/utils/SkRTConf.h#new...
include/utils/SkRTConf.h:93: SkRTConfRegistry();
On 2014/08/07 12:26:14, mtklein wrote:
> On 2014/08/07 03:05:40, tfarina wrote:
> > you will probably want me to keep the bool parameter, won't you?
> 
> I don't think so?   If this test works as written, it'd be better to delete
this
> alternative constructor entirely.  It's not being called.

Done.

https://codereview.chromium.org/444303002/diff/1/tests/RTConfRegistryTest.cpp
File tests/RTConfRegistryTest.cpp (right):

https://codereview.chromium.org/444303002/diff/1/tests/RTConfRegistryTest.cpp...
tests/RTConfRegistryTest.cpp:27: SkASSERT(result == 132);
On 2014/08/07 12:26:14, mtklein wrote:
> REPORTER_ASSERT?

Done.

[tfarina, 2014-08-08 02:58:58]

Changes made. ptal.

[mtklein, 2014-08-08 15:29:28]

lgtm

[tfarina, 2014-08-08 16:55:55]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-08-08 16:56:37]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/444303002/40001

[commit-bot: I haz the power, 2014-08-08 16:56:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 16:56:42]

Presubmit check for 444303002-40001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

[tfarina, 2014-08-08 16:59:22]

Brian, could you approve this?

[tfarina, 2014-08-12 02:54:04]

Ping.

[bsalomon, 2014-08-12 13:05:57]

On 2014/08/12 02:54:04, tfarina wrote:
> Ping.

lgtm

[tfarina, 2014-08-12 15:54:08]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-08-12 15:54:56]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/444303002/40001

[commit-bot: I haz the power, 2014-08-12 16:03:27]

Change committed as 35fbd014e3dd2b4e1813389da6dfa2d3482dfb67