Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 444253002: Prefs: Only use IDR_PREF_HASH_SEED_BIN in Chrome builds. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Prefs: Only use IDR_PREF_HASH_SEED_BIN in Chrome builds. BUG=333201 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
IDR_PREF_HASH_SEED_BIN shouldn't exist on non-Chrome builds, but does currently due to a bug in grit ...
6 years, 4 months ago (2014-08-06 23:57:49 UTC) #1
bbudge
LGTM
6 years, 4 months ago (2014-08-07 00:26:42 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-07 05:45:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/444253002/1
6 years, 4 months ago (2014-08-07 05:48:37 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-07 07:39:38 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 09:39:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/builds/4093)
6 years, 4 months ago (2014-08-07 09:39:56 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-07 16:24:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/444253002/1
6 years, 4 months ago (2014-08-07 16:25:44 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 22:50:22 UTC) #10
Message was sent while issue was closed.
Change committed as 288154

Powered by Google App Engine
This is Rietveld 408576698