Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 444223005: [SVG2] Svg elements that overflow the viewport should also be hitdetected. (Closed)

Created:
6 years, 4 months ago by Erik Dahlström (inactive)
Modified:
6 years, 4 months ago
Reviewers:
schenney, pdr.
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[SVG2] Svg elements that overflow the viewport should also be hittested. When we have an svg that doesn't clip to its viewport (aka overflow:visible), and there is some overflowing content, we need to consider the overflowing elements when hit testing. Otherwise it becomes impossible to interact with svg elements outside the viewport rect. BUG=401443 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179806

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
A LayoutTests/svg/custom/click-overflowing-element.html View 1 1 chunk +33 lines, -0 lines 0 comments Download
A + LayoutTests/svg/custom/click-overflowing-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Erik Dahlström (inactive)
6 years, 4 months ago (2014-08-07 13:10:37 UTC) #1
pdr.
LGTM It took me a little bit to understand that we are hit testing the ...
6 years, 4 months ago (2014-08-07 22:51:48 UTC) #2
Erik Dahlström (inactive)
The CQ bit was checked by ed@opera.com
6 years, 4 months ago (2014-08-08 07:37:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/444223005/20001
6 years, 4 months ago (2014-08-08 07:37:32 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 09:22:35 UTC) #5
Message was sent while issue was closed.
Change committed as 179806

Powered by Google App Engine
This is Rietveld 408576698