Go through root to get loading clients in StyleSheetContents::checkLoaded.

Go through root to get loading clients in StyleSheetContents::checkLoaded.

I accidentally used m_loadingClients instead of root->m_loadingClients
in https://codereview.chromium.org/196653006

R=esprehn@chromium.org, haraken@chromium.org

[haraken, 2014-08-07 08:00:19]

LGTM

[esprehn, 2014-08-07 08:03:26]

No test?

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Mads Ager (chromium), 2014-08-07 08:04:23]

Thanks Haraken. I'll go ahead and commit this. It is unfortunate that there are
no tests that fail because of this. I'm not familiar enough with how to exercise
this code path in examples. tasak, could you help out with attempting to write a
regression test for this issue as a follow-up?

[Mads Ager (chromium), 2014-08-07 08:05:32]

On 2014/08/07 08:03:26, esprehn wrote:
> No test?

Yeah, I know. :( Unfortunately, I don't know the code well enough to know how to
write a test for this. I'd like to commit this as the code that I wrote here is
obviously missing the access through root. I'm asking tasak if he can help me
create a regression test for this.

[Mads Ager (chromium), 2014-08-07 08:13:23]

The CQ bit was checked by ager@chromium.org

[commit-bot: I haz the power, 2014-08-07 08:14:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ager@chromium.org/444223004/1

[Mads Ager (chromium), 2014-08-07 08:17:16]

I filed http://crbug.com/401392 to track the addition of a regression test for
this.

[haraken, 2014-08-07 08:18:34]

tasak@ is now trying to figure out how to write a test. So let's wait for his
response, given that this isn't cause any serious crash.

[haraken, 2014-08-07 08:18:38]

The CQ bit was unchecked by haraken@chromium.org

[tasak, 2014-08-07 08:30:03]

On 2014/08/07 08:18:34, haraken wrote:
> tasak@ is now trying to figure out how to write a test. So let's wait for his
> response, given that this isn't cause any serious crash.

I will create a layout test for this. I think, the old code has style recalc
problem.

[Mads Ager (chromium), 2014-08-07 08:38:12]

On 2014/08/07 08:30:03, tasak wrote:
> On 2014/08/07 08:18:34, haraken wrote:
> > tasak@ is now trying to figure out how to write a test. So let's wait for
his
> > response, given that this isn't cause any serious crash.
> 
> I will create a layout test for this. I think, the old code has style recalc
> problem.

Thank you! :)

[tasak, 2014-08-07 13:12:00]

On 2014/08/07 13:10:36, tasak wrote:

I think, I found how to test this patch. I will create a layout test tomorrow
(JST).

[Mads Ager (chromium), 2014-08-07 13:14:24]

On 2014/08/07 13:12:00, tasak wrote:
> On 2014/08/07 13:10:36, tasak wrote:
> 
> I think, I found how to test this patch. I will create a layout test tomorrow
> (JST).

That is excellent. Thanks tasak. Feel free to upload the layout test and the
trivial fix as a separate code review and land it when you are done. Then I'll
close this issue. :)

[tasak, 2014-08-08 08:41:55]

On 2014/08/07 13:14:24, Mads Ager (chromium) wrote:
> On 2014/08/07 13:12:00, tasak wrote:
> > On 2014/08/07 13:10:36, tasak wrote:
> > 
> > I think, I found how to test this patch. I will create a layout test
tomorrow
> > (JST).
> 
> That is excellent. Thanks tasak. Feel free to upload the layout test and the
> trivial fix as a separate code review and land it when you are done. Then I'll
> close this issue. :)

I uploaded a patch:
https://codereview.chromium.org/456673002

Finally, I found that we need ASSERT(root==this);

[Mads Ager (chromium), 2014-08-11 06:25:27]

On 2014/08/08 08:41:55, tasak wrote:
> On 2014/08/07 13:14:24, Mads Ager (chromium) wrote:
> > On 2014/08/07 13:12:00, tasak wrote:
> > > On 2014/08/07 13:10:36, tasak wrote:
> > > 
> > > I think, I found how to test this patch. I will create a layout test
> tomorrow
> > > (JST).
> > 
> > That is excellent. Thanks tasak. Feel free to upload the layout test and the
> > trivial fix as a separate code review and land it when you are done. Then
I'll
> > close this issue. :)
> 
> I uploaded a patch:
> https://codereview.chromium.org/456673002
> 
> Finally, I found that we need ASSERT(root==this);

Thanks for investigating. Closing this issues. :)