Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: Source/web/WebMediaPlayerClientImpl.cpp

Issue 444173002: Let the effective media volume be 0 if the media element is muted (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebMediaPlayerClientImpl.cpp
diff --git a/Source/web/WebMediaPlayerClientImpl.cpp b/Source/web/WebMediaPlayerClientImpl.cpp
index e1e3724826298eedfdee8ea34cf7442f44aafbe1..835aa75f2d8a2f26587c4a5a62a6028ed5944cac 100644
--- a/Source/web/WebMediaPlayerClientImpl.cpp
+++ b/Source/web/WebMediaPlayerClientImpl.cpp
@@ -108,7 +108,7 @@ void WebMediaPlayerClientImpl::sizeChanged()
double WebMediaPlayerClientImpl::volume() const
acolwell GONE FROM CHROMIUM 2014/08/07 15:52:59 I'm assuming a followup CL to remove this function
philipj_slow 2014/08/07 15:59:28 Exactly, this CL is how I noticed this oddity. It
{
- return mediaElement().playerVolume();
+ return mediaElement().effectiveMediaVolume();
}
void WebMediaPlayerClientImpl::playbackStateChanged()
@@ -212,7 +212,7 @@ void WebMediaPlayerClientImpl::load(WebMediaPlayer::LoadType loadType, const WTF
m_audioSourceProvider.wrap(m_webMediaPlayer->audioSourceProvider());
#endif
- m_webMediaPlayer->setVolume(mediaElement().playerVolume());
+ m_webMediaPlayer->setVolume(mediaElement().effectiveMediaVolume());
m_webMediaPlayer->setPoster(poster);
« LayoutTests/media/effective-media-volume.html ('K') | « Source/core/testing/Internals.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698