Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: Source/core/html/MediaController.cpp

Issue 444173002: Let the effective media volume be 0 if the media element is muted (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/MediaController.cpp
diff --git a/Source/core/html/MediaController.cpp b/Source/core/html/MediaController.cpp
index f5997aeb5aa841748ce5aea53ce863f44dc4095e..65bd7db7f5bf0b675477152e2930cc728371d4b6 100644
--- a/Source/core/html/MediaController.cpp
+++ b/Source/core/html/MediaController.cpp
@@ -485,6 +485,9 @@ void MediaController::bringElementUpToSpeed(HTMLMediaElement* element)
// it must seek that media element to the MediaController's media controller position relative
// to the media element's timeline.
element->seek(currentTime(), IGNORE_EXCEPTION);
+
+ // Update volume to take controller volume and mute into account.
+ element->updateVolume();
}
bool MediaController::isRestrained() const

Powered by Google App Engine
This is Rietveld 408576698