Source/core/html/HTMLMediaElement.h - Issue 444173002: Let the effective media volume be 0 if the media element is muted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 444173002: Let the effective media volume be 0 if the media element is muted (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLMediaElement.h

diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h

index 8e57398939fa7621e5ae152e5d21ecdaa488dbe1..1d062560a4ca6264fc0da0b46d9157351eea507a 100644

--- a/Source/core/html/HTMLMediaElement.h

+++ b/Source/core/html/HTMLMediaElement.h

@@ -287,9 +287,8 @@ public:

void scheduleEvent(PassRefPtrWillBeRawPtr<Event>);

- // Current volume that should be used by the webMediaPlayer(). This method takes muted state

- // and m_mediaController multipliers into account.

- double playerVolume() const;

+ // Returns the "effective media volume" value as specified in the HTML5 spec.

+ double effectiveMediaVolume() const;

#if ENABLE(OILPAN)

bool isFinalizing() const { return m_isFinalizing; }