Let the effective media volume be 0 if the media element is muted

Source/web/WebMediaPlayerClientImpl.cpp

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "web/WebMediaPlayerClientImpl.h"
 
 #include "core/frame/LocalFrame.h"
 #include "core/html/HTMLMediaElement.h"
 #include "core/html/TimeRanges.h"
@@ skipping 88 matching lines @@
 void WebMediaPlayerClientImpl::durationChanged()
 {
     m_client->mediaPlayerDurationChanged();
 }
 
 void WebMediaPlayerClientImpl::sizeChanged()
 {
     m_client->mediaPlayerSizeChanged();
 }
 
 double WebMediaPlayerClientImpl::volume() const

[acolwell GONE FROM CHROMIUM, 2014/08/07 15:52:59]

I'm assuming a followup CL to remove this function is coming after
https://codereview.chromium.org/443393002/ lands.

[philipj_slow, 2014/08/07 15:59:28]

Exactly, this CL is how I noticed this oddity. It would be nice to get rid of
the setVolume in load() as well.

 {
-    return mediaElement().playerVolume();
+    return mediaElement().effectiveMediaVolume();
 }
 
 void WebMediaPlayerClientImpl::playbackStateChanged()
 {
     m_client->mediaPlayerPlaybackStateChanged();
 }
 
 WebMediaPlayer::Preload WebMediaPlayerClientImpl::preload() const
 {
     return static_cast<WebMediaPlayer::Preload>(m_preload);
@@ skipping 83 matching lines @@
     KURL kurl(ParsedURLString, url);
     m_webMediaPlayer = createWebMediaPlayer(this, kurl, frame);
     if (!m_webMediaPlayer)
         return;
 
 #if ENABLE(WEB_AUDIO)
     // Make sure if we create/re-create the WebMediaPlayer that we update our wrapper.
     m_audioSourceProvider.wrap(m_webMediaPlayer->audioSourceProvider());
 #endif
 
-    m_webMediaPlayer->setVolume(mediaElement().playerVolume());
+    m_webMediaPlayer->setVolume(mediaElement().effectiveMediaVolume());
 
     m_webMediaPlayer->setPoster(poster);
 
     // Tell WebMediaPlayer about any connected CDM (may be null).
     m_webMediaPlayer->setContentDecryptionModule(HTMLMediaElementEncryptedMedia::contentDecryptionModule(mediaElement()));
     m_webMediaPlayer->load(loadType, kurl, corsMode);
 }
 
 void WebMediaPlayerClientImpl::setPreload(MediaPlayer::Preload preload)
 {
@@ skipping 81 matching lines @@
 }
 
 void WebMediaPlayerClientImpl::AudioClientImpl::trace(Visitor* visitor)
 {
     visitor->trace(m_client);
 }
 
 #endif
 
 } // namespace blink