Issue 444163003: Move the rest of test_file_util to base namespace.

Issue 444163003: Move the rest of test_file_util to base namespace. (Closed)

Created:
6 years, 4 months ago by brettw

Modified:
6 years, 4 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, asanka, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, benjhayden+dwatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), erikwright+watch_chromium.org, ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move the rest of test_file_util to base namespace. R=rvargas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288158

Patch Set 1 #

Total comments: 3

Patch Set 2 : review comments #

Patch Set 3 : merge #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -75 lines)			Patch
M	base/file_util_unittest.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	base/files/file_path_watcher_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/test/run_all_unittests.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/test/test_file_util.h	View		1 chunk	+17 lines, -22 lines	0 comments	Download
M	base/test/test_file_util_android.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	base/test/test_file_util_posix.cc	View	1	1 chunk	+5 lines, -13 lines	0 comments	Download
M	base/test/test_file_util_win.cc	View	1	1 chunk	+5 lines, -13 lines	0 comments	Download
M	chrome/browser/download/download_browsertest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/download/download_path_reservation_tracker_unittest.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/browser/download/base_file_unittest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/download/download_file_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ipc/mojo/run_all_unittests.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/run_all_unittests.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/file_stream_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/http/http_network_transaction_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/spdy/spdy_network_transaction_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/test/run_all_unittests.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

lgtm after fixes. https://codereview.chromium.org/444163003/diff/1/base/test/test_file_util_android.cc File base/test/test_file_util_android.cc (right): https://codereview.chromium.org/444163003/diff/1/base/test/test_file_util_android.cc#newcode29 base/test/test_file_util_android.cc:29: } // namespace file_util base https://codereview.chromium.org/444163003/diff/1/base/test/test_file_util_posix.cc ...

6 years, 4 months ago (2014-08-06 23:21:49 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as 288158.

Expand Messages | Collapse Messages