components/dom_distiller/core/viewer.cc - Issue 444143002: Loading Indicator for Distilled Pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/core/viewer.cc

Issue 444143002: Loading Indicator for Distilled Pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: styling Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/dom_distiller/core/viewer.cc

diff --git a/components/dom_distiller/core/viewer.cc b/components/dom_distiller/core/viewer.cc

index be8463a3c67866bf2fc7a5efab6a58335f26232d..7e0eb285951e30de96f6a208f16c71feab5a07cc 100644

--- a/components/dom_distiller/core/viewer.cc

+++ b/components/dom_distiller/core/viewer.cc

@@ -75,11 +75,9 @@ std::string ReplaceHtmlTemplateValues(

substitutions.push_back(GetCssClass(theme)); // $4

substitutions.push_back(content); // $5

substitutions.push_back(loading_indicator_class); // $6

+ substitutions.push_back(original_url); // $7

substitutions.push_back(

- l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_VIEWER_LOADING_STRING)); // $7

- substitutions.push_back(original_url); // $8

- substitutions.push_back(

- l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_VIEWER_VIEW_ORIGINAL)); // $9

+ l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_VIEWER_VIEW_ORIGINAL)); // $8

return ReplaceStringPlaceholders(html_template, substitutions, NULL);

}

« no previous file with comments | « components/dom_distiller/core/css/distilledpage.css ('k') | no next file » | no next file with comments »