Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/dom_distiller/core/viewer.cc

Issue 444143002: Loading Indicator for Distilled Pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added closure Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/dom_distiller/content/resources/dom_distiller_viewer.js ('K') | « components/dom_distiller/core/css/distilledpage.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/dom_distiller/core/viewer.cc
diff --git a/components/dom_distiller/core/viewer.cc b/components/dom_distiller/core/viewer.cc
index be8463a3c67866bf2fc7a5efab6a58335f26232d..7e0eb285951e30de96f6a208f16c71feab5a07cc 100644
--- a/components/dom_distiller/core/viewer.cc
+++ b/components/dom_distiller/core/viewer.cc
@@ -75,11 +75,9 @@ std::string ReplaceHtmlTemplateValues(
substitutions.push_back(GetCssClass(theme)); // $4
substitutions.push_back(content); // $5
substitutions.push_back(loading_indicator_class); // $6
+ substitutions.push_back(original_url); // $7
substitutions.push_back(
- l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_VIEWER_LOADING_STRING)); // $7
- substitutions.push_back(original_url); // $8
- substitutions.push_back(
- l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_VIEWER_VIEW_ORIGINAL)); // $9
+ l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_VIEWER_VIEW_ORIGINAL)); // $8
return ReplaceStringPlaceholders(html_template, substitutions, NULL);
}
« components/dom_distiller/content/resources/dom_distiller_viewer.js ('K') | « components/dom_distiller/core/css/distilledpage.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698