chrome/chrome_browser.gypi - Issue 444123002: Adding a new delayed analysis that verify binaries signature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 444123002: Adding a new delayed analysis that verify binaries signature. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@grt

Patch Set: First round of comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/safe_browsing_service.cc ('K') | « chrome/browser/safe_browsing/safe_browsing_service.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 28b869cf16b66ea98ae1474509ae2306b9b60ba1..d34634749bbcecebc9958ab066b5b1b2b007c62e 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -2653,6 +2653,9 @@

'browser/safe_browsing/binary_feature_extractor.h',

'browser/safe_browsing/binary_feature_extractor_posix.cc',

'browser/safe_browsing/binary_feature_extractor_win.cc',

+ 'browser/safe_browsing/binary_integrity_analyzer.cc',

+ 'browser/safe_browsing/binary_integrity_analyzer.h',

+ 'browser/safe_browsing/binary_integrity_analyzer_win.cc',

'browser/safe_browsing/browser_feature_extractor.cc',

'browser/safe_browsing/browser_feature_extractor.h',

'browser/safe_browsing/browser_features.cc',

@@ -2708,6 +2711,8 @@

'browser/safe_browsing/safe_browsing_store.h',

'browser/safe_browsing/sandboxed_zip_analyzer.cc',

'browser/safe_browsing/sandboxed_zip_analyzer.h',

+ 'browser/safe_browsing/binary_integrity_incident_handlers.cc',

+ 'browser/safe_browsing/binary_integrity_incident_handlers.h',

mattm 2014/08/07 23:08:47 Think we're getting enough files to make a subdire

grt (UTC plus 2) 2014/08/08 02:23:06 sgtm.

pmonette_google.com 2014/08/08 15:05:43 I can do that.

'browser/safe_browsing/tracked_preference_incident_handlers.cc',

'browser/safe_browsing/tracked_preference_incident_handlers.h',

'browser/safe_browsing/two_phase_uploader.cc',