Adding a new delayed analysis that verify binaries signature.

chrome/common/safe_browsing/csd.proto

Index: chrome/common/safe_browsing/csd.proto
diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto
index 605f234fe56b5ddc9ebb6fe28dca98a60c11519d..005b995f4f80e1c9e67fd36d78a951f088933a3b 100644
--- a/chrome/common/safe_browsing/csd.proto
+++ b/chrome/common/safe_browsing/csd.proto
@@ -351,8 +351,13 @@ message ClientIncidentReport {
       repeated string split_key = 3;
       optional ValueState value_state = 4;
     }
+    message BinaryIntegrityIncident {
+      optional string file = 1;

[grt (UTC plus 2), 2014/08/07 02:12:46]

if this is only the name of the file rather than the path, please use
"file_basename", which matches the name of a similar field in
ClientDownloadRequest.

[pmonette_google.com, 2014/08/07 21:29:29]

In its current form, I am serializing the whole path to the file. But after
thinking about it again maybe just the basename is sufficient. Is there any
advantages to having the whole path instead of only the base name in your
opinion?

(Maybe finding where chrome is installed or identifying bugs but these are very
weak points)

[mattm, 2014/08/07 22:18:30]

If it does include the full path, should it use
PathSanitizer::StripHomeDirectory?

[grt (UTC plus 2), 2014/08/08 02:23:05]

Let's go with the basename for now. If we find that knowing where Chrome is
installed (sanitized, as Matt points out) useful, then we can add that as its
own thing in the environmental info.

[pmonette_google.com, 2014/08/08 15:05:42]

Done.

+      optional ClientDownloadRequest.SignatureInfo signature = 2;
+    }
     optional int64 incident_time_msec = 1;
     optional TrackedPreferenceIncident tracked_preference = 2;
+    optional BinaryIntegrityIncident binary_integrity = 3;
   }
 
   repeated IncidentData incident = 1;