Adding a new delayed analysis that verify binaries signature.

chrome/common/safe_browsing/csd.proto

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Client side phishing and malware detection request and response
 // protocol buffers.  Those protocol messages should be kept in sync
 // with the server implementation.
 //
 // If you want to change this protocol definition or you have questions
 // regarding its format please contact chrome-anti-phishing@googlegroups.com.
@@ skipping 333 matching lines @@
         WEAK_LEGACY_OBSOLETE = 2;
         CHANGED = 3;
         UNTRUSTED_UNKNOWN_VALUE = 4;
       }
 
       optional string path = 1;
       optional string atomic_value = 2;
       repeated string split_key = 3;
       optional ValueState value_state = 4;
     }
+    message BinaryIntegrityIncident {
+      optional string file = 1;

[grt (UTC plus 2), 2014/08/07 02:12:46]

if this is only the name of the file rather than the path, please use
"file_basename", which matches the name of a similar field in
ClientDownloadRequest.

[pmonette_google.com, 2014/08/07 21:29:29]

In its current form, I am serializing the whole path to the file. But after
thinking about it again maybe just the basename is sufficient. Is there any
advantages to having the whole path instead of only the base name in your
opinion?

(Maybe finding where chrome is installed or identifying bugs but these are very
weak points)

[mattm, 2014/08/07 22:18:30]

If it does include the full path, should it use
PathSanitizer::StripHomeDirectory?

[grt (UTC plus 2), 2014/08/08 02:23:05]

Let's go with the basename for now. If we find that knowing where Chrome is
installed (sanitized, as Matt points out) useful, then we can add that as its
own thing in the environmental info.

[pmonette_google.com, 2014/08/08 15:05:42]

Done.

+      optional ClientDownloadRequest.SignatureInfo signature = 2;
+    }
     optional int64 incident_time_msec = 1;
     optional TrackedPreferenceIncident tracked_preference = 2;
+    optional BinaryIntegrityIncident binary_integrity = 3;
   }
 
   repeated IncidentData incident = 1;
 
   message DownloadDetails {
     optional bytes token = 1;
     optional ClientDownloadRequest download = 2;
     optional int64 download_time_msec = 3;
     optional int64 open_time_msec = 4;
   }
@@ skipping 53 matching lines @@
 }
 
 message ClientIncidentResponse {
   optional bytes token = 1;
   optional bool download_requested = 2;
 
   message EnvironmentRequest { optional int32 dll_index = 1; }
 
   repeated EnvironmentRequest environment_requests = 3;
 }