Issue 444113002: Remove user chosen encoding flag from DocumentLoader::createWriterFor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 444113002: Remove user chosen encoding flag from DocumentLoader::createWriterFor (Closed)

Created:
6 years, 4 months ago by Nate Chapin

Modified:
6 years, 4 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove user chosen encoding flag from DocumentLoader::createWriterFor In practice, it is never set to true, since the only way for it to be set true is based on a previous DocumentWriter being set to true. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179867

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -20 lines)			Patch
M	Source/core/loader/DocumentLoader.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/loader/DocumentLoader.cpp	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/loader/DocumentWriter.h	View		3 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/core/loader/DocumentWriter.cpp	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/loader/TextResourceDecoderBuilder.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	Source/core/loader/TextResourceDecoderBuilder.cpp	View		3 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/444113002/20001

6 years, 4 months ago (2014-08-08 18:20:40 UTC) #4

Message was sent while issue was closed.

Change committed as 179867

Expand Messages | Collapse Messages