Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7770)

Unified Diff: chrome/test/data/webui/history_browsertest.js

Issue 444093003: history: left/right arrow should change focus even when history is read-only. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/history/history.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/history_browsertest.js
diff --git a/chrome/test/data/webui/history_browsertest.js b/chrome/test/data/webui/history_browsertest.js
index 96891840fe658e797b7f62f035dfe0f34abbf87d..3fc478c5397236fab67bf7158cd49aee2905fa84 100644
--- a/chrome/test/data/webui/history_browsertest.js
+++ b/chrome/test/data/webui/history_browsertest.js
@@ -778,7 +778,7 @@ TEST_F('HistoryWebUIRealBackendTest', 'basic', function() {
});
TEST_F('HistoryWebUIRealBackendTest', 'atLeastOneFocusable', function() {
- assertEquals(1, document.querySelectorAll('[tabindex="0"]').length);
+ expectEquals(1, document.querySelectorAll('[tabindex="0"]').length);
testDone();
});
@@ -827,6 +827,27 @@ TEST_F('HistoryWebUIRealBackendTest', 'singleDeletion', function() {
});
});
+TEST_F('HistoryWebUIRealBackendTest', 'leftRightChangeFocus', function() {
+ var visit = document.querySelector('.entry').visit;
+ visit.titleLink.focus();
+ assertEquals(visit.titleLink, document.activeElement);
+
+ var right = document.createEvent('KeyboardEvent');
+ right.initKeyboardEvent('keydown', true, true, window, 'Right');
+ assertEquals('Right', right.keyIdentifier);
+ expectFalse(visit.titleLink.dispatchEvent(right));
+
+ assertEquals(visit.dropDown, document.activeElement);
+
+ var left = document.createEvent('KeyboardEvent');
+ left.initKeyboardEvent('keydown', true, true, window, 'Left');
+ assertEquals('Left', left.keyIdentifier);
+ expectFalse(visit.dropDown.dispatchEvent(left));
+
+ expectEquals(visit.titleLink, document.activeElement);
+ testDone();
+});
+
/**
* Fixture for History WebUI testing when deletions are prohibited.
* @extends {HistoryWebUIRealBackendTest}
@@ -868,7 +889,28 @@ TEST_F('HistoryWebUIDeleteProhibitedTest', 'deleteProhibited', function() {
});
TEST_F('HistoryWebUIDeleteProhibitedTest', 'atLeastOneFocusable', function() {
- assertEquals(1, document.querySelectorAll('[tabindex="0"]').length);
+ expectEquals(1, document.querySelectorAll('[tabindex="0"]').length);
+ testDone();
+});
+
+TEST_F('HistoryWebUIDeleteProhibitedTest', 'leftRightChangeFocus', function() {
+ var visit = document.querySelector('.entry').visit;
+ visit.titleLink.focus();
+ assertEquals(visit.titleLink, document.activeElement);
+
+ var right = document.createEvent('KeyboardEvent');
+ right.initKeyboardEvent('keydown', true, true, window, 'Right');
+ assertEquals('Right', right.keyIdentifier);
+ expectFalse(visit.titleLink.dispatchEvent(right));
+
+ assertEquals(visit.dropDown, document.activeElement);
+
+ var left = document.createEvent('KeyboardEvent');
+ left.initKeyboardEvent('keydown', true, true, window, 'Left');
+ assertEquals('Left', left.keyIdentifier);
+ expectFalse(visit.dropDown.dispatchEvent(left));
+
+ expectEquals(visit.titleLink, document.activeElement);
testDone();
});
« no previous file with comments | « chrome/browser/resources/history/history.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698