Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 444093003: history: left/right arrow should change focus even when history is read-only. (Closed)

Created:
6 years, 4 months ago by Dan Beam
Modified:
6 years, 4 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

history: left/right arrow should change focus even when history is read-only. R=estade@chromium.org BUG=393489 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288421

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
M chrome/browser/resources/history/history.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/webui/history_browsertest.js View 3 chunks +44 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dan Beam
6 years, 4 months ago (2014-08-06 22:43:49 UTC) #1
Dan Beam
ping
6 years, 4 months ago (2014-08-08 17:29:30 UTC) #2
Evan Stade
lgtm
6 years, 4 months ago (2014-08-08 18:14:24 UTC) #3
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 4 months ago (2014-08-08 18:23:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/444093003/1
6 years, 4 months ago (2014-08-08 18:29:12 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 20:12:44 UTC) #6
Message was sent while issue was closed.
Change committed as 288421

Powered by Google App Engine
This is Rietveld 408576698