Respect output_all_resource_defines when generating resource maps.

Respect output_all_resource_defines when generating structures in resource maps.

BUG=chromium:333201
TEST=included unit test.

[Lei Zhang, 2014-08-06 20:59:23]

Not sure who has time to review this...

[tony, 2014-08-06 21:11:59]

LGTM.  Can you update the description to say that it wasn't working properly for
<structures> nodes?

[tony, 2014-08-06 21:13:31]

https://codereview.chromium.org/444053003/diff/1/grit/format/resource_map.py
File grit/format/resource_map.py (right):

https://codereview.chromium.org/444053003/diff/1/grit/format/resource_map.py#...
grit/format/resource_map.py:115: message.MessageNode)):
This code and the isinstance checks below are a little gross.  Would be nice to
move this into methods off of node in a separate refactoring change.  *shrug*

[Lei Zhang, 2014-08-06 21:41:08]

https://codereview.chromium.org/444053003/diff/1/grit/format/resource_map.py
File grit/format/resource_map.py (right):

https://codereview.chromium.org/444053003/diff/1/grit/format/resource_map.py#...
grit/format/resource_map.py:115: message.MessageNode)):
On 2014/08/06 21:13:31, tony wrote:
> This code and the isinstance checks below are a little gross.  Would be nice
to
> move this into methods off of node in a separate refactoring change.  *shrug*

Done.

[tony, 2014-08-06 21:45:21]

Much better!  LGTM.  Do you need me to commit the change?

[Lei Zhang, 2014-08-06 21:49:08]

On 2014/08/06 21:45:21, tony wrote:
> Much better!  LGTM.  Do you need me to commit the change?

Yes please.

[tony, 2014-08-06 21:54:52]

Running presubmit commit checks ...

Presubmit checks took 1.1s to calculate.

Presubmit checks passed.
Sending        grit/format/resource_map.py
Sending        grit/format/resource_map_unittest.py
Sending        grit/node/base.py
Sending        grit/node/include.py
Sending        grit/node/message.py
Sending        grit/node/structure.py
Transmitting file data ......
Committed revision 172.