Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 444033003: Rename FullscreenElementStack::requestFullScreenForElement to requestFullscreen (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
falken
CC:
blink-reviews, philipj_slow, feature-media-reviews_chromium.org, gasubic, sof, eae+blinkwatch, fs, eric.carlson_apple.com, vcarbune.chromium, blink-reviews-dom_chromium.org, dglazkov+blink, nessy, blink-reviews-html_chromium.org, rwlbuis
Project:
blink
Visibility:
Public.

Description

Rename FullscreenElementStack::requestFullScreenForElement to requestFullscreen It's unambigious without the suffix, and now matches the spec: http://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen If there ever was any disambiguity about document fullscreen vs. element fullscreen, there isn't any longer, at least not here. BUG=383813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/dom/Element.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL. Obviously conflicts with https://codereview.chromium.org/449133003/ but I'll aim to land this first and resolve the ...
6 years, 4 months ago (2014-08-07 21:59:51 UTC) #1
falken
On 2014/08/07 21:59:51, philipj wrote: > PTAL. Obviously conflicts with https://codereview.chromium.org/449133003/ but > I'll aim ...
6 years, 4 months ago (2014-08-08 02:31:02 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-08 05:04:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/444033003/1
6 years, 4 months ago (2014-08-08 05:04:55 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 05:08:29 UTC) #5
Message was sent while issue was closed.
Change committed as 179787

Powered by Google App Engine
This is Rietveld 408576698