Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 444023002: Extend some operations to range types. (Closed)

Created:
6 years, 4 months ago by neis
Modified:
6 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Extend some operations to range types. This is a reland of 22934, which failed to build on Windows due to a missing include, and on ARM due to a name clash with some predefined constants. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -16 lines) Patch
M src/types.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/types.cc View 10 chunks +54 lines, -2 lines 0 comments Download
M test/cctest/test-types.cc View 6 chunks +27 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
neis
6 years, 4 months ago (2014-08-06 15:13:15 UTC) #1
rossberg
LGTM (Usually it's good to indicate in the CL name that it is a reland, ...
6 years, 4 months ago (2014-08-06 15:57:18 UTC) #2
neis
6 years, 4 months ago (2014-08-06 17:23:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 22945 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698