[telemetry] Disable IPPET power monitor

[telemetry] Disable IPPET power monitor

Disable IPPET power monitor added in https://codereview.chromium.org/394923003/. The win8 perf bot (http://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf%20%281%29)
became pretty flaky right after this power monitoring patch landed. Some of the failures are clearly
IPPET-related, but others are silent timeouts which also appeared around the same time.

Sample failures:

- AssertionError: Called StartMonitoringPower() twice.
http://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf%20%281%29/builds/2561/steps/page_cycler.dhtml/logs/stdio

- IppetError: Timed out waiting for IPPET to close.
http://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf%20%281%29/builds/2540/steps/page_cycler.dhtml/logs/stdio

- TimeoutException: Timed out while waiting 5s for IppetServerIsUp.
http://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf%20%281%29/builds/2551/steps/page_cycler.dhtml/logs/stdio

- Generic timeout
http://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf%20%281%29/builds/2558/steps/page_cycler.intl_ar_fa_he/logs/stdio

Original issue's description:
> [telemetry] Add IPPET power monitor.
>
> This power monitor lets our automated testers track power usage on Windows on Intel Sandy Bridge or later.
>
>
> BUG=336558, 153139
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286541

R=rmcilroy@chromium.org, tonyg@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287779

[Sami, 2014-08-06 13:14:11]

Created Revert of [telemetry] Add IPPET power monitor.

[commit-bot: I haz the power, 2014-08-06 13:15:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skyostil@chromium.org/443973002/1

[commit-bot: I haz the power, 2014-08-06 13:15:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-06 13:15:08]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Sami, 2014-08-06 13:59:10]

Ross, care have a look?

https://codereview.chromium.org/443973002/diff/160001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py
(right):

https://codereview.chromium.org/443973002/diff/160001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py:75:
if (not win32event) or True:
FWIW, I did this instead of "return False" to avoid a lint error about
unreachable code.

[rmcilroy, 2014-08-06 14:06:14]

https://codereview.chromium.org/443973002/diff/160001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py
(right):

https://codereview.chromium.org/443973002/diff/160001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py:75:
if (not win32event) or True:
On 2014/08/06 13:59:10, Sami wrote:
> FWIW, I did this instead of "return False" to avoid a lint error about
> unreachable code.

nit - could you just do an:
if True:
  return False
if not win32event...
or is the lint catcher smart enough about that?  Otherwise lgtm.

[Sami, 2014-08-06 14:23:50]

On 2014/08/06 14:06:14, rmcilroy wrote:
> nit - could you just do an:
> if True:
>   return False
> if not win32event...
> or is the lint catcher smart enough about that?  Otherwise lgtm.

That seems to work, thanks!

[Sami, 2014-08-06 14:23:53]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2014-08-06 14:24:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skyostil@chromium.org/443973002/170001

[tonyg, 2014-08-06 14:33:09]

Thanks for going the disable route instead of the full revert :-)

Hopefully we can figure out the issues here.

lgtm

[Sami, 2014-08-06 16:23:39]

Committed patchset #3 manually as 287779 (tree was closed).