Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: src/code-stubs.h

Issue 443963002: Always use the StoreFieldStub to do the actual storing. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm64/stub-cache-arm64.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_CODE_STUBS_H_ 5 #ifndef V8_CODE_STUBS_H_
6 #define V8_CODE_STUBS_H_ 6 #define V8_CODE_STUBS_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/assembler.h" 9 #include "src/assembler.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 972 matching lines...) Expand 10 before | Expand all | Expand 10 after
983 int property_index_key = index_.GetFieldAccessStubKey(); 983 int property_index_key = index_.GetFieldAccessStubKey();
984 bit_field_ = EncodedStoreFieldByIndexBits::encode(property_index_key) | 984 bit_field_ = EncodedStoreFieldByIndexBits::encode(property_index_key) |
985 RepresentationBits::encode( 985 RepresentationBits::encode(
986 PropertyDetails::EncodeRepresentation(representation)); 986 PropertyDetails::EncodeRepresentation(representation));
987 } 987 }
988 988
989 virtual Handle<Code> GenerateCode() V8_OVERRIDE; 989 virtual Handle<Code> GenerateCode() V8_OVERRIDE;
990 990
991 FieldIndex index() const { return index_; } 991 FieldIndex index() const { return index_; }
992 Representation representation() { return representation_; } 992 Representation representation() { return representation_; }
993 static void InstallDescriptors(Isolate* isolate);
993 994
994 protected: 995 protected:
995 explicit StoreFieldStub(Isolate* isolate); 996 explicit StoreFieldStub(Isolate* isolate);
996 virtual Code::Kind kind() const { return Code::STORE_IC; } 997 virtual Code::Kind kind() const { return Code::STORE_IC; }
997 virtual Code::StubType GetStubType() { return Code::FAST; } 998 virtual Code::StubType GetStubType() { return Code::FAST; }
998 999
999 private: 1000 private:
1000 class EncodedStoreFieldByIndexBits : public BitField<int, 0, 13> {}; 1001 class EncodedStoreFieldByIndexBits : public BitField<int, 0, 13> {};
1001 class RepresentationBits : public BitField<int, 13, 4> {}; 1002 class RepresentationBits : public BitField<int, 13, 4> {};
1002 virtual CodeStub::Major MajorKey() const { return StoreField; } 1003 virtual CodeStub::Major MajorKey() const { return StoreField; }
(...skipping 1506 matching lines...) Expand 10 before | Expand all | Expand 10 after
2509 2510
2510 2511
2511 class CallDescriptors { 2512 class CallDescriptors {
2512 public: 2513 public:
2513 static void InitializeForIsolate(Isolate* isolate); 2514 static void InitializeForIsolate(Isolate* isolate);
2514 }; 2515 };
2515 2516
2516 } } // namespace v8::internal 2517 } } // namespace v8::internal
2517 2518
2518 #endif // V8_CODE_STUBS_H_ 2519 #endif // V8_CODE_STUBS_H_
OLDNEW
« no previous file with comments | « src/arm64/stub-cache-arm64.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698