Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 443963002: Always use the StoreFieldStub to do the actual storing. (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Always use the StoreFieldStub to do the actual storing. BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22931

Patch Set 1 #

Patch Set 2 : Also install the descriptor for StoreFieldStub #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -245 lines) Patch
M src/arm/stub-cache-arm.cc View 1 2 1 chunk +17 lines, -66 lines 0 comments Download
M src/arm64/stub-cache-arm64.cc View 1 2 1 chunk +17 lines, -66 lines 0 comments Download
M src/code-stubs.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stubs.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +16 lines, -49 lines 0 comments Download
M src/ic.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/stub-cache.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +1 line, -8 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +16 lines, -50 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-06 12:47:38 UTC) #1
Yang
On 2014/08/06 12:47:38, Toon Verwaest wrote: > PTAL LGTM.
6 years, 4 months ago (2014-08-06 12:51:42 UTC) #2
Toon Verwaest
6 years, 4 months ago (2014-08-06 13:18:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as 22931 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698