Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 443953002: Move WebViewShell from Android to Chromium (Closed)

Created:
6 years, 4 months ago by hjd
Modified:
6 years, 4 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move WebViewShell from Android to Chromium This lets us build the WebViewShell via ninja using the target android_webview_telemetry_shell_apk. the licence information was updated to use the Chromium licence and the package was changed to: org.chromium.telemetry_shell This meant updating: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py to use the new package name. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288698

Patch Set 1 #

Patch Set 2 : Update for feedback. #

Patch Set 3 : Update telemetry browser name. #

Patch Set 4 : Update package name in another place. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -9 lines) Patch
A android_webview/android_webview_telemetry_shell.gyp View 1 1 chunk +17 lines, -0 lines 0 comments Download
A android_webview/tools/WebViewTelemetryShell/Android.mk View 1 1 chunk +14 lines, -0 lines 0 comments Download
A android_webview/tools/WebViewTelemetryShell/AndroidManifest.xml View 1 1 chunk +40 lines, -0 lines 0 comments Download
A android_webview/tools/WebViewTelemetryShell/res/drawable/ic_launcher.png View 1 Binary file 0 comments Download
A + android_webview/tools/WebViewTelemetryShell/res/layout/activity_telemetry.xml View 1 1 chunk +11 lines, -4 lines 0 comments Download
A + android_webview/tools/WebViewTelemetryShell/res/values/strings.xml View 1 1 chunk +3 lines, -3 lines 0 comments Download
A android_webview/tools/WebViewTelemetryShell/src/org/chromium/telemetry_shell/JankActivity.java View 1 1 chunk +46 lines, -0 lines 0 comments Download
A android_webview/tools/WebViewTelemetryShell/src/org/chromium/telemetry_shell/TelemetryActivity.java View 1 1 chunk +38 lines, -0 lines 0 comments Download
M build/all.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
hjd
Okay I move the WebViewShell to Chrome, just trying to run the bot locally now. ...
6 years, 4 months ago (2014-08-06 12:01:04 UTC) #1
mkosiba (inactive)
On 2014/08/06 12:01:04, hjd wrote: > Okay I move the WebViewShell to Chrome, just trying ...
6 years, 4 months ago (2014-08-06 13:09:42 UTC) #2
mkosiba (inactive)
+benm for thoughts.
6 years, 4 months ago (2014-08-06 13:11:22 UTC) #3
hjd
tonyg@: Could you do an OWNERS review for: android_browser_backend.py android_browser_finder.py? This change updates the package ...
6 years, 4 months ago (2014-08-08 13:47:24 UTC) #4
hjd
6 years, 4 months ago (2014-08-08 16:25:06 UTC) #5
mkosiba (inactive)
lgtm
6 years, 4 months ago (2014-08-11 10:28:19 UTC) #6
hjd
-tonyg@ who looks snowed under +skyostil@ (I didn't realize there was an OWNER in my ...
6 years, 4 months ago (2014-08-11 10:41:59 UTC) #7
Sami
Telemetry shell sounds a bit odd but lgtm since I don't have a better suggestion.
6 years, 4 months ago (2014-08-11 11:05:10 UTC) #8
hjd
The CQ bit was checked by hjd@chromium.org
6 years, 4 months ago (2014-08-11 11:17:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hjd@chromium.org/443953002/60001
6 years, 4 months ago (2014-08-11 11:17:15 UTC) #10
hjd
On 2014/08/11 11:05:10, Sami wrote: > Telemetry shell sounds a bit odd but lgtm since ...
6 years, 4 months ago (2014-08-11 11:21:55 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 13:41:26 UTC) #12
Message was sent while issue was closed.
Change committed as 288698

Powered by Google App Engine
This is Rietveld 408576698