Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 443943002: DevTools: Fix framework blackboxing for exceptions thrown inside V8 internal scripts. (Closed)

Created:
6 years, 4 months ago by aandrey
Modified:
6 years, 4 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, blink-reviews-bindings_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix framework blackboxing for exceptions thrown inside V8 internal scripts. BUG=267592 R=yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179616

Patch Set 1 #

Patch Set 2 : fixed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -36 lines) Patch
M LayoutTests/inspector/console/console-error-on-call-frame-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/inspector/sources/debugger/frameworks-skip-exceptions.html View 3 chunks +11 lines, -29 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/frameworks-skip-exceptions-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/resources/framework.js View 1 chunk +22 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/DebuggerScript.js View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.cpp View 1 chunk +13 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 4 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
aandrey
6 years, 4 months ago (2014-08-06 11:23:48 UTC) #1
yurys
lgtm
6 years, 4 months ago (2014-08-06 11:34:52 UTC) #2
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-08-06 11:35:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/443943002/1
6 years, 4 months ago (2014-08-06 11:36:30 UTC) #4
aandrey
The CQ bit was unchecked by aandrey@chromium.org
6 years, 4 months ago (2014-08-06 11:38:48 UTC) #5
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-08-06 11:57:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/443943002/20001
6 years, 4 months ago (2014-08-06 11:58:47 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 14:39:33 UTC) #8
Message was sent while issue was closed.
Change committed as 179616

Powered by Google App Engine
This is Rietveld 408576698