Move objects-visiting into heap.

Move objects-visiting into heap.

BUG=
R=jochen@chromium.org, mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22971

[jochen (gone - plz use gerrit), 2014-08-06 10:55:11]

lgtm

[Michael Starzinger, 2014-08-06 11:35:29]

https://codereview.chromium.org/443933002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/443933002/diff/1/BUILD.gn#newcode659
BUILD.gn:659: "src/heap/objects-visiting.cc",
nit: Can we add the "-inl.h" file as well?

https://codereview.chromium.org/443933002/diff/1/src/heap/objects-visiting-inl.h
File src/heap/objects-visiting-inl.h (right):

https://codereview.chromium.org/443933002/diff/1/src/heap/objects-visiting-in...
src/heap/objects-visiting-inl.h:870: void Code::CodeIterateBody(Heap* heap) {
Please keep this static visitor method near the virtual dispatch visitor (as
discussed offline) in the objects-inl.h file.

https://codereview.chromium.org/443933002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/443933002/diff/1/src/objects.cc#newcode11561
src/objects.cc:11561: void Code::CodeIterateBody(ObjectVisitor* v) {
Would it be possible to move this into the objects-inl.h file?

https://codereview.chromium.org/443933002/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/443933002/diff/1/tools/gyp/v8.gyp#newcode560
tools/gyp/v8.gyp:560: '../../src/heap/objects-visiting.cc',
nit: Can we add the "-inl.h" file as well?

[Hannes Payer (out of office), 2014-08-07 11:12:03]

https://codereview.chromium.org/443933002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/443933002/diff/1/BUILD.gn#newcode659
BUILD.gn:659: "src/heap/objects-visiting.cc",
On 2014/08/06 11:35:29, Michael Starzinger wrote:
> nit: Can we add the "-inl.h" file as well?

Done.

https://codereview.chromium.org/443933002/diff/1/src/heap/objects-visiting-inl.h
File src/heap/objects-visiting-inl.h (right):

https://codereview.chromium.org/443933002/diff/1/src/heap/objects-visiting-in...
src/heap/objects-visiting-inl.h:870: void Code::CodeIterateBody(Heap* heap) {
On 2014/08/06 11:35:29, Michael Starzinger wrote:
> Please keep this static visitor method near the virtual dispatch visitor (as
> discussed offline) in the objects-inl.h file.

I had to move them back to objects-visiting because of crazy include
dependencies :(

https://codereview.chromium.org/443933002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/443933002/diff/1/src/objects.cc#newcode11561
src/objects.cc:11561: void Code::CodeIterateBody(ObjectVisitor* v) {
On 2014/08/06 11:35:29, Michael Starzinger wrote:
> Would it be possible to move this into the objects-inl.h file?

Unfortunately, this is not easy.

https://codereview.chromium.org/443933002/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/443933002/diff/1/tools/gyp/v8.gyp#newcode560
tools/gyp/v8.gyp:560: '../../src/heap/objects-visiting.cc',
On 2014/08/06 11:35:29, Michael Starzinger wrote:
> nit: Can we add the "-inl.h" file as well?

Done.

[Michael Starzinger, 2014-08-07 11:31:22]

LGTM.

[Hannes Payer (out of office), 2014-08-07 12:21:20]

Committed patchset #3 manually as 22971 (presubmit successful).