Issue 44393003: Devirtualize several SVG classes destructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 44393003: Devirtualize several SVG classes destructors (Closed)

Created:
7 years, 1 month ago by Inactive

Modified:
7 years, 1 month ago

Reviewers:
Stephen Chennney

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, f(malita), darktears, pdr, Stephen Chennney, Steve Block, dino_apple.com, Eric Willigers

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Devirtualize several SVG classes destructors Devirtualize several SVG classes destructors as these classes are never subclassed, nor do they have any virtual function. This avoids creating unnecessary vtables. BUG=311561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160606

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -8 lines)			Patch
M	Source/core/svg/SVGAnimatedType.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGElementInstanceList.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGElementInstanceList.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/svg/SVGViewSpec.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/44393003/1

7 years, 1 month ago (2013-10-25 17:20:09 UTC) #3

Message was sent while issue was closed.

Change committed as 160606

Expand Messages | Collapse Messages