Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 443883003: Test for registering the same SW in different frames (Closed)

Created:
6 years, 4 months ago by falken
Modified:
6 years, 4 months ago
Reviewers:
michaeln, nhiroki
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Test for registering the same Service Worker in different frames BUG=400980 R=nhiroki@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179693

Patch Set 1 #

Patch Set 2 : missing semicolon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M LayoutTests/http/tests/serviceworker/multiple-register.html View 1 3 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
falken
6 years, 4 months ago (2014-08-06 09:29:55 UTC) #1
nhiroki
lgtm
6 years, 4 months ago (2014-08-06 09:42:15 UTC) #2
falken
The CQ bit was checked by falken@chromium.org
6 years, 4 months ago (2014-08-07 02:10:12 UTC) #3
falken
The CQ bit was unchecked by falken@chromium.org
6 years, 4 months ago (2014-08-07 02:10:39 UTC) #4
falken
The CQ bit was checked by falken@chromium.org
6 years, 4 months ago (2014-08-07 02:12:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/443883003/20001
6 years, 4 months ago (2014-08-07 02:12:44 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-07 03:37:34 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 04:38:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/20212)
6 years, 4 months ago (2014-08-07 04:38:50 UTC) #9
falken
The CQ bit was checked by falken@chromium.org
6 years, 4 months ago (2014-08-07 04:45:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/443883003/20001
6 years, 4 months ago (2014-08-07 04:45:37 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-07 05:47:20 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 05:53:17 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/20228)
6 years, 4 months ago (2014-08-07 05:53:18 UTC) #14
falken
The CQ bit was checked by falken@chromium.org
6 years, 4 months ago (2014-08-07 07:23:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/443883003/20001
6 years, 4 months ago (2014-08-07 07:24:19 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-07 08:23:00 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 08:36:41 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/20257)
6 years, 4 months ago (2014-08-07 08:36:42 UTC) #19
falken
6 years, 4 months ago (2014-08-07 08:41:57 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 manually as 179693 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698