Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 443873007: Expand Enums for (fake) Omnibox Histograms (Closed)

Created:
6 years, 4 months ago by Mark P
Modified:
6 years, 4 months ago
Reviewers:
vadimb, vadimb1
CC:
chromium-reviews, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Expand Enums for (fake) Omnibox Histograms These histograms are derived from OmniboxEvent log entries. Some new types are appearing in some new logs nowadays. TBR=vadimb BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mark P
Vadim, Please take a look. thanks, mark
6 years, 4 months ago (2014-08-06 18:33:34 UTC) #1
vadimb1
lgtm
6 years, 4 months ago (2014-08-06 22:23:01 UTC) #2
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 4 months ago (2014-08-06 22:26:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/443873007/1
6 years, 4 months ago (2014-08-06 22:28:38 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 22:28:39 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-06 22:28:40 UTC) #6
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 4 months ago (2014-08-06 22:29:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/443873007/1
6 years, 4 months ago (2014-08-06 22:31:01 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 00:37:26 UTC) #9
Message was sent while issue was closed.
Change committed as 287916

Powered by Google App Engine
This is Rietveld 408576698