Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/browser/geolocation/geolocation_infobar_delegate.cc

Issue 443873003: Remove 'Learn More' Link from the geolocation infobar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/geolocation/geolocation_infobar_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/geolocation/geolocation_infobar_delegate.cc
diff --git a/chrome/browser/geolocation/geolocation_infobar_delegate.cc b/chrome/browser/geolocation/geolocation_infobar_delegate.cc
index e7d70e716335fce5b85b8baf0b7541e11eaf436f..79fa9d843e7387d0c491e35fd1b37f9222ab681a 100644
--- a/chrome/browser/geolocation/geolocation_infobar_delegate.cc
+++ b/chrome/browser/geolocation/geolocation_infobar_delegate.cc
@@ -45,7 +45,7 @@ enum GeolocationInfoBarDelegateEvent {
GEOLOCATION_INFO_BAR_DELEGATE_EVENT_DISMISS = 3,
// User clicked on link.
- GEOLOCATION_INFO_BAR_DELEGATE_EVENT_LINK_CLICK = 4,
+ DEPRECATED_GEOLOCATION_INFO_BAR_DELEGATE_EVENT_LINK_CLICK = 4,
// User ignored the bar.
GEOLOCATION_INFO_BAR_DELEGATE_EVENT_IGNORED = 5,
@@ -163,28 +163,3 @@ bool GeolocationInfoBarDelegate::Cancel() {
SetPermission(true, false);
return true;
}
-
-base::string16 GeolocationInfoBarDelegate::GetLinkText() const {
- return l10n_util::GetStringUTF16(IDS_LEARN_MORE);
-}
-
-bool GeolocationInfoBarDelegate::LinkClicked(
- WindowOpenDisposition disposition) {
- RecordUmaEvent(GEOLOCATION_INFO_BAR_DELEGATE_EVENT_LINK_CLICK);
- const char kGeolocationLearnMoreUrl[] =
-#if defined(OS_CHROMEOS)
- "https://www.google.com/support/chromeos/bin/answer.py?answer=142065";
-#elif defined(OS_ANDROID)
- "https://support.google.com/chrome/?p=mobile_location";
-#else
- "https://www.google.com/support/chrome/bin/answer.py?answer=142065";
-#endif
-
- InfoBarService::WebContentsFromInfoBar(infobar())->OpenURL(
- content::OpenURLParams(
- GURL(kGeolocationLearnMoreUrl),
- content::Referrer(),
- (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
- content::PAGE_TRANSITION_LINK, false));
- return false; // Do not dismiss the info bar.
-}
« no previous file with comments | « chrome/browser/geolocation/geolocation_infobar_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698