Issue 443873002: Hydrogenize (and share) StoreField except heapobject (for now).

Issue 443873002: Hydrogenize (and share) StoreField except heapobject (for now). (Closed)

Created:
6 years, 4 months ago by Toon Verwaest

Modified:
6 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Hydrogenize (and share) StoreField except heapobject (for now). BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22909

Patch Set 4 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+182 lines, -309 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1 2	2 chunks	+30 lines, -81 lines	0 comments	Download
M	src/arm64/stub-cache-arm64.cc	View	1 2	2 chunks	+30 lines, -83 lines	0 comments	Download
M	src/code-stubs.h	View	1 2 3	3 chunks	+32 lines, -7 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View		2 chunks	+38 lines, -0 lines	0 comments	Download
M	src/field-index.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		1 chunk	+23 lines, -73 lines	0 comments	Download
M	src/ic.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 2	1 chunk	+23 lines, -64 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comments. https://codereview.chromium.org/443873002/diff/2/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/443873002/diff/2/src/code-stubs.h#newcode987 src/code-stubs.h:987: ; I don't think this is ...

6 years, 4 months ago (2014-08-06 09:19:41 UTC) #2

Toon Verwaest

https://codereview.chromium.org/443873002/diff/2/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/443873002/diff/2/src/code-stubs.h#newcode987 src/code-stubs.h:987: ; On 2014/08/06 09:19:41, Jakob wrote: > I don't ...

6 years, 4 months ago (2014-08-06 09:26:37 UTC) #3

Toon Verwaest

6 years, 4 months ago (2014-08-06 09:31:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as 22909 (presubmit successful).

Expand Messages | Collapse Messages