Mirror object properties are always names

src/mirror-debugger.js

 // Copyright 2006-2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Handle id counters.
 var next_handle_ = 0;
 var next_transient_handle_ = -1;
 
 // Mirror cache.
 var mirror_cache_ = [];
@@ skipping 741 matching lines @@
   // Copy names for named properties.
   if (kind & PropertyKind.Named) {
     for (var i = 0; index < limit && i < propertyNames.length; i++) {
       names[index++] = propertyNames[i];
     }
   }
 
   // Copy names for indexed properties.
   if (kind & PropertyKind.Indexed) {
     for (var i = 0; index < limit && i < elementNames.length; i++) {
-      names[index++] = elementNames[i];
+      names[index++] = %ToString(elementNames[i]);

[rossberg, 2014/08/06 14:21:30]

Hm, I don't understand why this change is necessary.

     }
   }
 
   return names;
 };
 
 
 /**
  * Return the properties for this object as an array of PropertyMirror objects.
  * @param {number} kind Indicate whether named, indexed or both kinds of
@@ skipping 17 matching lines @@
  * Return the internal properties for this object as an array of
  * InternalPropertyMirror objects.
  * @return {Array} Property mirrors for this object
  */
 ObjectMirror.prototype.internalProperties = function() {
   return ObjectMirror.GetInternalProperties(this.value_);
 }
 
 
 ObjectMirror.prototype.property = function(name) {
-  var details = %DebugGetPropertyDetails(this.value_, %ToString(name));
+  name = IS_SYMBOL(name) ? name : %ToString(name);

[rossberg, 2014/08/06 14:21:29]

You can use %ToName for this.

+  var details = %DebugGetPropertyDetails(this.value_, name);
   if (details) {
     return new PropertyMirror(this, name, details);
   }
 
   // Nothing found.
   return GetUndefinedMirror();
 };
 
 
 
@@ skipping 539 matching lines @@
   while (!(next = iter.next()).done) {
     result.push(next.value);
   }
   return result;
 };
 
 
 /**
  * Base mirror object for properties.
  * @param {ObjectMirror} mirror The mirror object having this property
- * @param {string} name The name of the property
+ * @param {Name} name The name of the property (a string or a symbol)
  * @param {Array} details Details about the property
  * @constructor
  * @extends Mirror
  */
 function PropertyMirror(mirror, name, details) {
   %_CallFunction(this, PROPERTY_TYPE, Mirror);
   this.mirror_ = mirror;
   this.name_ = name;
   this.value_ = details[0];
   this.details_ = details[1];
@@ skipping 1508 matching lines @@
   }
   if (!NUMBER_IS_FINITE(value)) {
     if (value > 0) {
       return 'Infinity';
     } else {
       return '-Infinity';
     }
   }
   return value;
 }