Adds ChromecastConfig to manage cast_shell's PrefService.

Adds ChromecastConfig to manage cast_shell's PrefService.

R=lcwu@chromium.org,jam@chromium.org
BUG=336640
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288292

[jam, 2014-08-07 05:46:59]

lgtm with nit

https://codereview.chromium.org/443833002/diff/1/chromecast/common/cast_paths.cc
File chromecast/common/cast_paths.cc (right):

https://codereview.chromium.org/443833002/diff/1/chromecast/common/cast_paths...
chromecast/common/cast_paths.cc:29: case PATH_CAST_CONFIG: {
nit: the convention in paths files is to name enums starting with DIR_ or FILE_

[gunsch, 2014-08-08 00:10:40]

Thanks for the quick review.

https://codereview.chromium.org/443833002/diff/1/chromecast/common/cast_paths.cc
File chromecast/common/cast_paths.cc (right):

https://codereview.chromium.org/443833002/diff/1/chromecast/common/cast_paths...
chromecast/common/cast_paths.cc:29: case PATH_CAST_CONFIG: {
On 2014/08/07 05:46:59, jam wrote:
> nit: the convention in paths files is to name enums starting with DIR_ or
FILE_

Done.

[lcwu1, 2014-08-08 00:22:39]

https://codereview.chromium.org/443833002/diff/20001/chromecast/common/cast_p...
File chromecast/common/cast_paths.cc (right):

https://codereview.chromium.org/443833002/diff/20001/chromecast/common/cast_p...
chromecast/common/cast_paths.cc:33: *result = data_dir.Append(".eureka.conf");
Why not name the config file the same as Chromecast?

https://codereview.chromium.org/443833002/diff/20001/chromecast/common/cast_p...
File chromecast/common/cast_paths.h (right):

https://codereview.chromium.org/443833002/diff/20001/chromecast/common/cast_p...
chromecast/common/cast_paths.h:20: // "$HOME/.eureka.conf".
s/.eureka.conf/cast_shell.conf, or simply don't mention what the default value
is (so that if in the future the default path is modified in .cc file, we don't
have to remember to come here to change the comment).

[gunsch, 2014-08-08 00:26:36]

https://codereview.chromium.org/443833002/diff/20001/chromecast/common/cast_p...
File chromecast/common/cast_paths.cc (right):

https://codereview.chromium.org/443833002/diff/20001/chromecast/common/cast_p...
chromecast/common/cast_paths.cc:33: *result = data_dir.Append(".eureka.conf");
On 2014/08/08 00:22:38, lcwu1 wrote:
> Why not name the config file the same as Chromecast?

Whoa, this is backwards. Thanks for catching. It was not a 1:1 port from our
downstream, since that was handling this condition at a different code point.

This should be .eureka.conf for Chromecast (to stay with the existing file on
the device). I suspect that needs to remain permanently/until we decide to do a
one-time copy, so we don't lose the preferences.

"cast_shell.conf" was the name we settled on as a better "new name" for Android
build.

https://codereview.chromium.org/443833002/diff/20001/chromecast/common/cast_p...
File chromecast/common/cast_paths.h (right):

https://codereview.chromium.org/443833002/diff/20001/chromecast/common/cast_p...
chromecast/common/cast_paths.h:20: // "$HOME/.eureka.conf".
On 2014/08/08 00:22:38, lcwu1 wrote:
> s/.eureka.conf/cast_shell.conf, or simply don't mention what the default value
> is (so that if in the future the default path is modified in .cc file, we
don't
> have to remember to come here to change the comment).

Done.

[lcwu1, 2014-08-08 00:33:12]

lgtm

[gunsch, 2014-08-08 00:36:29]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2014-08-08 00:54:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gunsch@chromium.org/443833002/40001

[commit-bot: I haz the power, 2014-08-08 10:00:24]

Change committed as 288292