[SyncFS] Clear dirty flag on changelist application phase

[SyncFS] Clear dirty flag on changelist application phase

Clear trivially solvable dirty flag in earlier phase than before, so that consecutive local changes doesn't conflict to each other.

BUG=344769
TEST=unit_tests --gtest_filter=DriveBackendSyncTest.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289271

[tzik, 2014-08-07 09:26:46]

PTL

[peria, 2014-08-07 09:40:43]

https://codereview.chromium.org/443793003/diff/20001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/443793003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1368:
index_->EnumerateDirtyTrackers(base::Bind(
This code looks too complicated to me.
Can't we do in following style?

std::vector<int64> tracker_ids = index_->EnumerateDirtyTrackers();
VisitTrackerToSweep(tracker_ids);  // Rename?
for (size_t i = 0; ....  // #1372-

[tzik, 2014-08-12 15:14:31]

Could you take another look?

https://codereview.chromium.org/443793003/diff/20001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/443793003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1368:
index_->EnumerateDirtyTrackers(base::Bind(
On 2014/08/07 09:40:43, peria wrote:
> This code looks too complicated to me.
> Can't we do in following style?
> 
> std::vector<int64> tracker_ids = index_->EnumerateDirtyTrackers();
> VisitTrackerToSweep(tracker_ids);  // Rename?
> for (size_t i = 0; ....  // #1372-

OK, revised.

[peria, 2014-08-13 09:04:08]

https://codereview.chromium.org/443793003/diff/40001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/443793003/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1394: if
(!CanClearDirty(*itr))
Could you merge GetFileTracker(id, tracker_ptr) on #1396-1397 and #1934-1938 in
CanClearDirty()?

[tzik, 2014-08-13 09:30:03]

https://codereview.chromium.org/443793003/diff/40001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/443793003/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1394: if
(!CanClearDirty(*itr))
On 2014/08/13 09:04:08, peria wrote:
> Could you merge GetFileTracker(id, tracker_ptr) on #1396-1397 and #1934-1938
in
> CanClearDirty()?

Done.

[peria, 2014-08-13 09:31:41]

lgtm

[tzik, 2014-08-13 09:35:04]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-08-13 09:38:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/443793003/60001

[commit-bot: I haz the power, 2014-08-13 10:52:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-13 12:25:21]

Change committed as 289271