Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 443793002: Revert of Fix and reenable checkbox in Polymer page set. (Closed)

Created:
6 years, 4 months ago by tonyg
Modified:
6 years, 4 months ago
Reviewers:
wiltzius, dtu, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix and reenable checkbox in Polymer page set. (https://codereview.chromium.org/437353002/) Reason for revert: Fails on N5 (at least). Unhandled exception while running http://www.polymer-project.org/components/paper-elements/demo.html#paper-checkbox Traceback (most recent call last): _RunPage at tools/telemetry/telemetry/page/page_runner.py:533 test.RunPage(page, page_state.tab, results) RunPage at tools/telemetry/telemetry/page/page_test.py:232 self._RunMethod(page, self._action_name_to_run, action_runner) _RunMethod at tools/telemetry/telemetry/page/page_test.py:241 run_method(action_runner) RunSmoothness at tools/perf/page_sets/polymer.py:124 self.TouchEverything(action_runner) TouchEverything at tools/perf/page_sets/polymer.py:154 self.DoActionOnWidgetType(action_runner, tappable_type, self.TapWidget) DoActionOnWidgetType at tools/perf/page_sets/polymer.py:169 element_query + '.offsetParent != null'): EvaluateJavaScript at tools/telemetry/telemetry/page/actions/action_runner.py:148 return self._tab.EvaluateJavaScript(expression) EvaluateJavaScript at tools/telemetry/telemetry/core/web_contents.py:108 expr, context_id=None, timeout=timeout) EvaluateJavaScriptInContext at tools/telemetry/telemetry/core/web_contents.py:124 expr, context_id=context_id, timeout=timeout) EvaluateJavaScript at tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py:176 return self._runtime.Evaluate(expr, context_id, timeout) Evaluate at tools/telemetry/telemetry/core/backends/chrome/inspector_runtime.py:46 raise exceptions.EvaluateException(res['result']['result']['description']) EvaluateException: TypeError: Cannot read property 'offsetParent' of undefined Locals: context_id : None expr : 'document.querySelector("sampler-scaffold").$.frame.contentDocument.querySelectorAll("body paper-checkbox:not([disabled]):not([active]):not([checked])")[2].offsetParent != null' request : {'params': {'returnByValue': True, 'expression': 'document.querySelector("sampler-scaffold").$.frame.contentDocument.querySelectorAll("body paper-checkbox:not([disabled]):not([active]):not([checked])")[2].offsetParent != null'}, 'method': 'Runtime.evaluate', 'id': 173} res : {u'id': 173, u'result': {u'wasThrown': True, u'exceptionDetails': {u'url': u'', u'text': u"Uncaught TypeError: Cannot read property 'offsetParent' of undefined", u'line': 1, u'column': 68}, u'result': {u'className': u'TypeError', u'type': u'object', u'description': u"TypeError: Cannot read property 'offsetParent' of undefined", u'objectId': u'{"injectedScriptId":4,"id":1}'}}} timeout : 90 http://chromegw/i/chromium.perf/builders/Android%20Nexus5%20Perf/builds/1213/steps/smoothness.polymer/logs/stdio Original issue's description: > Fix and reenable checkbox in Polymer page set. > > BUG=394756 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287596 TBR=dtu@chromium.org,nduca@chromium.org,wiltzius@chromium.org NOTREECHECKS=true NOTRY=true BUG=394756 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M tools/perf/page_sets/polymer.py View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tonyg
Created Revert of Fix and reenable checkbox in Polymer page set.
6 years, 4 months ago (2014-08-06 02:55:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/443793002/1
6 years, 4 months ago (2014-08-06 02:57:13 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 02:59:58 UTC) #3
Message was sent while issue was closed.
Change committed as 287667

Powered by Google App Engine
This is Rietveld 408576698