Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: Source/core/rendering/RenderLayer.h

Issue 443773002: Delete UpdateLayerPositionsFlags (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 LayoutRect rect() const { return LayoutRect(location(), size()); } 146 LayoutRect rect() const { return LayoutRect(location(), size()); }
147 147
148 bool isRootLayer() const { return m_isRootLayer; } 148 bool isRootLayer() const { return m_isRootLayer; }
149 149
150 RenderLayerCompositor* compositor() const; 150 RenderLayerCompositor* compositor() const;
151 151
152 // Notification from the renderer that its content changed (e.g. current fra me of image changed). 152 // Notification from the renderer that its content changed (e.g. current fra me of image changed).
153 // Allows updates of layer content without invalidating paint. 153 // Allows updates of layer content without invalidating paint.
154 void contentChanged(ContentChangeType); 154 void contentChanged(ContentChangeType);
155 155
156 enum UpdateLayerPositionsFlag { 156 void updateLayerPositionsAfterLayout();
157 UpdatePagination = 1 << 0,
158 };
159 typedef unsigned UpdateLayerPositionsFlags;
160
161 void updateLayerPositionsAfterLayout(UpdateLayerPositionsFlags);
162 void updateLayerPositionsAfterOverflowScroll(); 157 void updateLayerPositionsAfterOverflowScroll();
163 158
164 // FIXME: Should updateLayerPositions be private?
165 void updateLayerPositionRecursive(UpdateLayerPositionsFlags = 0);
166
167 bool isPaginated() const { return m_isPaginated; } 159 bool isPaginated() const { return m_isPaginated; }
168 RenderLayer* enclosingPaginationLayer() const { return m_enclosingPagination Layer; } 160 RenderLayer* enclosingPaginationLayer() const { return m_enclosingPagination Layer; }
169 161
170 void updateTransformationMatrix(); 162 void updateTransformationMatrix();
171 RenderLayer* renderingContextRoot(); 163 RenderLayer* renderingContextRoot();
172 164
173 const LayoutSize& offsetForInFlowPosition() const { return m_offsetForInFlow Position; } 165 const LayoutSize& offsetForInFlowPosition() const { return m_offsetForInFlow Position; }
174 166
175 void blockSelectionGapsBoundsChanged(); 167 void blockSelectionGapsBoundsChanged();
176 void addBlockSelectionGapsBounds(const LayoutRect&); 168 void addBlockSelectionGapsBounds(const LayoutRect&);
(...skipping 381 matching lines...) Expand 10 before | Expand all | Expand 10 after
558 550
559 void setAncestorChainHasSelfPaintingLayerDescendant(); 551 void setAncestorChainHasSelfPaintingLayerDescendant();
560 void dirtyAncestorChainHasSelfPaintingLayerDescendantStatus(); 552 void dirtyAncestorChainHasSelfPaintingLayerDescendantStatus();
561 553
562 void clipToRect(const LayerPaintingInfo&, GraphicsContext*, const ClipRect&, PaintLayerFlags, BorderRadiusClippingRule = IncludeSelfForBorderRadius); 554 void clipToRect(const LayerPaintingInfo&, GraphicsContext*, const ClipRect&, PaintLayerFlags, BorderRadiusClippingRule = IncludeSelfForBorderRadius);
563 void restoreClip(GraphicsContext*, const LayoutRect& paintDirtyRect, const C lipRect&); 555 void restoreClip(GraphicsContext*, const LayoutRect& paintDirtyRect, const C lipRect&);
564 556
565 // Returns true if the position changed. 557 // Returns true if the position changed.
566 bool updateLayerPosition(); 558 bool updateLayerPosition();
567 559
560 void updateLayerPositionRecursive();
568 void updateLayerPositionsAfterScrollRecursive(); 561 void updateLayerPositionsAfterScrollRecursive();
569 562
570 void setNextSibling(RenderLayer* next) { m_next = next; } 563 void setNextSibling(RenderLayer* next) { m_next = next; }
571 void setPreviousSibling(RenderLayer* prev) { m_previous = prev; } 564 void setPreviousSibling(RenderLayer* prev) { m_previous = prev; }
572 void setFirstChild(RenderLayer* first) { m_first = first; } 565 void setFirstChild(RenderLayer* first) { m_first = first; }
573 void setLastChild(RenderLayer* last) { m_last = last; } 566 void setLastChild(RenderLayer* last) { m_last = last; }
574 567
575 LayoutPoint renderBoxLocation() const { return renderer()->isBox() ? toRende rBox(renderer())->location() : LayoutPoint(); } 568 LayoutPoint renderBoxLocation() const { return renderer()->isBox() ? toRende rBox(renderer())->location() : LayoutPoint(); }
576 569
577 void paintLayerContentsAndReflection(GraphicsContext*, const LayerPaintingIn fo&, PaintLayerFlags); 570 void paintLayerContentsAndReflection(GraphicsContext*, const LayerPaintingIn fo&, PaintLayerFlags);
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 void updateTransform(const RenderStyle* oldStyle, RenderStyle* newStyle); 645 void updateTransform(const RenderStyle* oldStyle, RenderStyle* newStyle);
653 646
654 void dirty3DTransformedDescendantStatus(); 647 void dirty3DTransformedDescendantStatus();
655 // Both updates the status, and returns true if descendants of this have 3d. 648 // Both updates the status, and returns true if descendants of this have 3d.
656 bool update3DTransformedDescendantStatus(); 649 bool update3DTransformedDescendantStatus();
657 650
658 void updateOrRemoveFilterClients(); 651 void updateOrRemoveFilterClients();
659 652
660 LayoutRect paintingExtent(const RenderLayer* rootLayer, const LayoutRect& pa intDirtyRect, const LayoutSize& subPixelAccumulation, PaintBehavior); 653 LayoutRect paintingExtent(const RenderLayer* rootLayer, const LayoutRect& pa intDirtyRect, const LayoutSize& subPixelAccumulation, PaintBehavior);
661 654
655 void updatePaginationRecursive(bool needsPaginationUpdate = false);
662 void updatePagination(); 656 void updatePagination();
663 657
664 // FIXME: Temporary. Remove when new columns come online. 658 // FIXME: Temporary. Remove when new columns come online.
665 bool useRegionBasedColumns() const; 659 bool useRegionBasedColumns() const;
666 660
667 LayerType m_layerType; 661 LayerType m_layerType;
668 662
669 // Self-painting layer is an optimization where we avoid the heavy RenderLay er painting 663 // Self-painting layer is an optimization where we avoid the heavy RenderLay er painting
670 // machinery for a RenderLayer allocated only to handle the overflow clip ca se. 664 // machinery for a RenderLayer allocated only to handle the overflow clip ca se.
671 // FIXME(crbug.com/332791): Self-painting layer should be merged into the ov erflow-only concept. 665 // FIXME(crbug.com/332791): Self-painting layer should be merged into the ov erflow-only concept.
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
778 772
779 } // namespace blink 773 } // namespace blink
780 774
781 #ifndef NDEBUG 775 #ifndef NDEBUG
782 // Outside the WebCore namespace for ease of invocation from gdb. 776 // Outside the WebCore namespace for ease of invocation from gdb.
783 void showLayerTree(const blink::RenderLayer*); 777 void showLayerTree(const blink::RenderLayer*);
784 void showLayerTree(const blink::RenderObject*); 778 void showLayerTree(const blink::RenderObject*);
785 #endif 779 #endif
786 780
787 #endif // RenderLayer_h 781 #endif // RenderLayer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698