Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: net/quic/crypto/quic_crypto_client_config.cc

Issue 443763002: QUIC - Added Net.QuicClientHelloServerConfig.InvalidDuration histogram (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: UMA_HISTOGRAM_CUSTOM_TIMES can only have a maximum value of 25 days Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/quic_crypto_client_config.cc
diff --git a/net/quic/crypto/quic_crypto_client_config.cc b/net/quic/crypto/quic_crypto_client_config.cc
index d00e67677df1c62763bf662f04d2c9ed28a8dc51..18c0d541de5c2a5258d6c8919e88adcd20b9999a 100644
--- a/net/quic/crypto/quic_crypto_client_config.cc
+++ b/net/quic/crypto/quic_crypto_client_config.cc
@@ -40,7 +40,7 @@ enum ServerConfigState {
SERVER_CONFIG_INVALID = 1,
SERVER_CONFIG_CORRUPTED = 2,
SERVER_CONFIG_EXPIRED = 3,
- SERVER_CONFIG_INVALID_EXPIRY_SECONDS = 4,
+ SERVER_CONFIG_INVALID_EXPIRY = 4,
// NOTE: Add new server config states only immediately above this line. Make
// sure to update the QuicServerConfigState enum in
@@ -89,13 +89,14 @@ bool QuicCryptoClientConfig::CachedState::IsComplete(QuicWallTime now) const {
uint64 expiry_seconds;
if (scfg->GetUint64(kEXPY, &expiry_seconds) != QUIC_NO_ERROR) {
- RecordServerConfigState(SERVER_CONFIG_INVALID_EXPIRY_SECONDS);
+ RecordServerConfigState(SERVER_CONFIG_INVALID_EXPIRY);
return false;
}
if (now.ToUNIXSeconds() >= expiry_seconds) {
- UMA_HISTOGRAM_TIMES(
- "Net.QuicClientHelloServerConfig.HowExpired",
- base::TimeDelta::FromSeconds(now.ToUNIXSeconds() - expiry_seconds));
+ UMA_HISTOGRAM_CUSTOM_TIMES(
+ "Net.QuicClientHelloServerConfig.InvalidDuration",
+ base::TimeDelta::FromSeconds(now.ToUNIXSeconds() - expiry_seconds),
+ base::TimeDelta::FromMinutes(1), base::TimeDelta::FromDays(20), 50);
RecordServerConfigState(SERVER_CONFIG_EXPIRED);
return false;
}
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698