Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 443763002: QUIC - Added Net.QuicClientHelloServerConfig.InvalidDuration histogram (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, wtc, Alexei Svitkine (slow), Ryan Hamilton
Project:
chromium
Visibility:
Public.

Description

QUIC - Added Net.QuicClientHelloServerConfig.InvalidDuration histogram to track server config expiration from 1 minute to 30 days. Minor cleanup of names and description of server config expiry and use of inchoate ClientHello. Fixed wtc's comments for CL: https://codereview.chromium.org/413363005/ R=jar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287895

Patch Set 1 #

Patch Set 2 : UMA_HISTOGRAM_CUSTOM_TIMES can only have a maximum value of 25 days #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M net/quic/crypto/quic_crypto_client_config.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ramant (doing other things)
6 years, 4 months ago (2014-08-05 22:06:48 UTC) #1
wtc
Patch set 1 LGTM.
6 years, 4 months ago (2014-08-05 23:15:40 UTC) #2
jar (doing other things)
lgtm
6 years, 4 months ago (2014-08-05 23:21:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/443763002/1
6 years, 4 months ago (2014-08-05 23:22:25 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-06 04:07:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 04:44:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/3324)
6 years, 4 months ago (2014-08-06 04:44:55 UTC) #7
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 4 months ago (2014-08-06 19:12:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/443763002/20001
6 years, 4 months ago (2014-08-06 19:14:05 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 23:32:14 UTC) #10
Message was sent while issue was closed.
Change committed as 287895

Powered by Google App Engine
This is Rietveld 408576698